RePod / psdle

Improving everyone's favorite online download list, one loop at a time.
https://repod.github.io/psdle
MIT License
193 stars 14 forks source link

Generated list omits some content from my account #7

Closed Goliz closed 9 years ago

Goliz commented 9 years ago

I have thousands of entries on my PSN download list, including games, DLC, themes, demos, avatars, and so on. However, the list omits around 30 of those entries (out of a total of 2448... that's my situation, others will have different numbers, of course) if i generate it with the option "Catalog" enabled. If i disable it, the list is generated quickly, and it shows exactly 2448 entries. The omitted content is mostly stuff obtained years ago. I thought keeping "Catalog" enabled gave more accurate results?

RePod commented 9 years ago

If I had to guess it's due to the systems being detected on the hidden content not being those actually allowed (PS1/2/3/4/P/V) thus while PSDLE does acknowledge them it doesn't consider them valid to the search options selected. Another possible cause is the Catalog setting is detecting them as something other than what's available and changing them from "Unknown", which would also hide them.

I could either include an "Other" system category (which ignores these checks), buckle down on Catalog parsing (which would be bad), or ensure those ones get set to a system they can actually be used on. Since it sounds like you may know what's already being excluded would it be too much to ask if you name those content items (and on what store language)?

To ease in finding the problem content in question follow these steps:

Goliz commented 9 years ago

I'm afraid i don't know what i'm supposed to do with that URL. Are you sure the steps are correct? I've never ever used the console before.

RePod commented 9 years ago

The URL contains a modified version of the PSDLE javascript. You should be able to execute it from the browser console.

In Firefox it would look like so: (your color/theme might be different) console chrome

Goliz commented 9 years ago

Ok, i've found around 19 "Bad sys?" entries, but a lot more "Bad type?". What should i do now?

Anyway, the "Bad" entries are all for old PSP stuff obtained ages ago, mostly DLC.

I use the ITALIAN store, by the way.

ps: just checked again, your modified script gives a lot more omitted content. Probably more than 200.

RePod commented 9 years ago

Posting a few of of the results would help, then I'll check them on the Italian language web store.

Goliz commented 9 years ago

I just copy-pasted all of them, should be easy to check though: http://pastebin.com/FnUJXuyv

RePod commented 9 years ago

Please do the same steps as above but with this url.

I think I found the problem. Also, most of the "bad type?" from before were due to the logging line being in the wrong place, it is now where it should be for testing.

Goliz commented 9 years ago

Well, now i'm getting a lot more omitted results than before (711, basically most of my pre-2012 content), but the "bad" entries are still 200 as before, although all of them are "Bad sys?" this time: http://pastebin.com/P4wfdW3b

RePod commented 9 years ago

Please try this url. Thanks! Also the inclusion of even more omitted content is most likely due to forgetting to add a space (" ") in the checks so "PS Vita" was failing to be detected.

It seems to be some extra characters are getting into the system names through Catalog (specifically Ⓡ in "PSP", so "PSPⓇ"), so I just need to clean those up that seems to be fix. If this is the solution I'll most likely rewrite the system detection section to be more strict than it was before.

Goliz commented 9 years ago

No problem. Now it shows 2448 out of 2448 entries, like it should be. No need to post anything.

I always thought those entries were omitted on purpose.

ps: on a side note, are you ever planning to enable export for the icons?

RePod commented 9 years ago

Great! Time to rewrite the system detection. Expect the live version to have it within 24 hours, or 4 with how fast I code.

As for exporting, if there is demand for it I prioritize it. The entire export option was done on a whim before anybody actually requested it and people just used it. It needs to be rewritten so people can pick exactly what they want.

However, running _JSON.stringify(repod.psdle.gamelistcur) in the console will return a string of all information PSDLE has on the current view in JSON format. Paired with prompt() you should be able to easily copy it.

Goliz commented 9 years ago

I see, thank you. I don't understand how to properly use that command, though...