search

RePod / psdle

Improving everyone's favorite online download list, one loop at a time.
https://repod.github.io/psdle
MIT License
194 stars 14 forks source link

Use ISO 8601 combined date and time for download file name #71

Closed windsurfer1122 closed 5 years ago

windsurfer1122 commented 5 years ago

Browser: Chrome

Method: Extension

Online store version and language: Desktop

PSDLE version: 3.3.13

Monkey variant: n/a

Is Catalog enabled: Yes

Problem: The downloaded file name uses always US style date and time format, which is annoying for sorting. Can you change to ISO 8601 combined date and time format? Timezone would be irrelevant. See https://en.wikipedia.org/wiki/ISO_8601#Combined_date_and_time_representations

How to replicate: Just export any list with Chrome

Other notes:

RePod commented 5 years ago

Here's hoping casual end users don't take issue.

windsurfer1122 commented 5 years ago

The casual user won't, but people who keep track of their purchases and archive their lists.

windsurfer1122 commented 5 years ago

On Firefox PSDLE creates a different date/time format in the download file name.

windsurfer1122 commented 5 years ago

Just recognized you already changed that :)

windsurfer1122 commented 5 years ago

Works great in Chrome, also handles colons for the time.

windsurfer1122 commented 5 years ago

Side note to the commit: The concatenated underscore should be removed and moved to the actual parameters. To avoid the unintended trailing underscore in file names like "psdle_2019-06-19T21_5234.289Z.json" Add underscore to the fallback "generic.txt" plus the single call with not only an extension.

"download" : "psdle_"+(new Date().toISOString())+(download || "_generic.txt"), repod.psdle.exportList.download("_raw.json",JSON.stringify(raw))