ReScience / rescience.github.io

ReScience website sources
rescience.github.io
Creative Commons Attribution Share Alike 4.0 International
36 stars 42 forks source link

Add Courtès:2020 and Hinsen:2020 #81

Closed otizonaizit closed 4 years ago

otizonaizit commented 4 years ago

Here I am adding two publications:

The second one though has a duplicate bibtex label, because the previously published article https://github.com/ReScience/articles/tree/master/10.5281_zenodo.3886447 has the very same (automatically generated) bibtex label. Should I change the Hinsen:2020 label to something like Hinsen:2020_2 both here and in the https://github.com/ReScience/articles repo? Or what are your thoughts about it, @khinsen and @rougier ?

Also, see my comment below...

otizonaizit commented 4 years ago

Before merging, I have a question: is the label Courtès:2020 (with the UTF-8 character) a valid bibtex keyword?

rougier commented 4 years ago

It's mostly for the web so I would say it's fine but just in case, you can use "Courtes". In any case, it's only internal.

rougier commented 4 years ago

@otizonaizit Can you modify the label (courtès -> courtes)?

otizonaizit commented 4 years ago

@rougier : what about the issue with the duplicated label?

otizonaizit commented 4 years ago

I tried to fix the ASCII/UTF-8 problem at the origin here: https://github.com/ReScience/articles/pull/6

rougier commented 4 years ago

For authors having duplicate labels, best is to append a,b, c... In this case: khinsen:2020a and khinsen:2020b.

otizonaizit commented 4 years ago

so you are proposing for me to change (both here and in the articles repo) to change the bibtex label of both hinsen:2020 papers?

On Mon 15 Jun, 05:28 -0700, "Nicolas P. Rougier" notifications@github.com wrote:

For authors having duplicate labels, best is to append a,b, c... In this case: khinsen:2020a and khinsen:2020b.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub¹, or unsubscribe².☘

––––

¹ https://github.com/ReScience/rescience.github.io/pull/81#issuecomment-644101979 ² https://github.com/notifications/unsubscribe-auth/AACUYC2BT223TZAPHFEOVRDRWYHWBANCNFSM4N3NJF3Q

rougier commented 4 years ago

Yes. Or you can only add a b to the newest khinsen:2020 entry. I did not think about this problem when I write the bibtex generator. Parsing the website bibfile would be overkill but I wondered the how did you spot the duplicated entry ?

In anycase, those identifiers are not really used outside the website such that how they are named is not really important (or is it ?). Another option would be to add khinsen:rescience:2020:3:1 (year:volume:number)

otizonaizit commented 4 years ago

I just pushed the solution which adds a and b to the two papers. This comes with a companion pull request to fix this in the articles repository: https://github.com/ReScience/articles/pull/7

rougier commented 4 years ago

I think you need to rebase your bibfile (there's a merge conflict on your PR)

otizonaizit commented 4 years ago

Yes. Or you can only add a b to the newest khinsen:2020 entry. I did not think about this problem when I write the bibtex generator. Parsing the website bibfile would be overkill but I wondered the how did you spot the duplicated entry ?

I spot it because the other Hinsen:2020 was just the last paper added before I added my two new ones ;-)

In anycase, those identifiers are not really used outside the website such that how they are named is not really important (or is it ?). Another option would be to add khinsen:rescience:2020:3:1 (year:volume:number)

I do not know if we may ever want to use this in real bibtex. But I think that the idea of using: FirstAuthorLastName:Year:Volume:Issue:Number will at least make sure that the labels are unique. And this could be extracted automatically from the yaml file without parsing the website. Or, use FirstAuthorLastName:DOI?

otizonaizit commented 4 years ago

OK, I rebased. It should be fine now...

rougier commented 4 years ago

Perfect. Thanks.