ReScience / submissions

ReScience C submissions
28 stars 7 forks source link

Review Request: C. de la Torre-Ortiz and A. Nioche #10

Closed c-torre closed 3 years ago

c-torre commented 4 years ago

Dear ReScience editors,

I request a review for the following replication:

Original article: https://doi.org/10.3389/fncom.2015.00149

PDF URL: https://github.com/c-torre/replication-recanatesi-2015/blob/master/re-neural-network-model-of-memory-retrieval.pdf Metadata URL: https://github.com/c-torre/replication-recanatesi-2015/blob/master/metadata.tex Code URL: https://github.com/c-torre/replication-recanatesi-2015/

Scientific domain: Computational Neuroscience Programming language: Python Suggested editor: @oliviaguest

c-torre commented 3 years ago

Updated template, corrected latex errors and added code to software heritage (c-torre/replication-recanatesi-2015-article)

rougier commented 3 years ago

Thanks, I'll try to publish it today. For the swh link, can you send the swid (instead of the url) ? You should have received it when you saved the repo. The article template will complete the full url based on this id.

rougier commented 3 years ago

Here is the sanboxed version (not the real one): https://sandbox.zenodo.org/record/719803 Can you check everything looks good ?

c-torre commented 3 years ago

Sandboxed version looks good.

For the SWID, the only thing I seem to find is a "permalink" hidden in a SWH side bar:

swh:1:dir:0b541aeb4707ecedfbbcdd85adfd0100d748cc03;
origin=https://github.com/c-torre/replication-recanatesi-2015/;
visit=swh:1:snp:0fd6c99fcc42679041cee0c384bfd4a0ffa0a50e;
anchor=swh:1:rev:59a3c88f5e7af41d4bf748ac4c41e03bdb2722da

https://archive.softwareheritage.org/browse/origin/directory/?origin_url=https://github.com/c-torre/replication-recanatesi-2015/

Is it any of these?

rougier commented 3 years ago

First one (swh:1:dir:0b541aeb4707ecedfbbcdd85adfd0100d748cc03) is good yes, I'll include it. Thanks.

rougier commented 3 years ago

Your article is published at https://zenodo.org/record/4461767. It will appear soon on the ReScience website as well. Congratulations !

rougier commented 3 years ago

@oliviaguest Feel free to close the issue. @c-torre I'll make a PR onto your repo with my modifications.

oliviaguest commented 3 years ago

Thank you all for this! Nice work. 😊