search

ReVanced / revanced-branding

🎨 Brandings, guidelines, kits and assets of ReVanced
https://revanced.app
GNU General Public License v3.0
83 stars 10 forks source link

bug: unnecessary padding around the logo in some variants #22

Closed Ushie closed 9 months ago

Ushie commented 9 months ago

Issue

ReVanced Logo Shape Dark and ReVanced Logo Shape Light have unnecessary padding around the logos

This padding does not exist on the regular ReVanced Logo Shape variant

This makes it impossible to use as an icon in frontend, as no-matter where you place the icon it will barely be visible due to how small it actually is

oSumAtrIX commented 9 months ago

If we remove the padding, how will you match the correct padding when you need it?

Ushie commented 9 months ago

These assets are meant for use in frontends, whether it is as a reference, an icon to a list item, an icon to a button, or whatever, in all of these instances it would require modification to the provided asset just to be able to use it

As to "when you need it", I don't know when that would be the case and I also don't know how you would resolve this issue

Ushie commented 9 months ago

I also don't see anything related to padding in the Branding Guidelines, it's most likely that these assets were exported during the same time the full logo was and the padding was left in by mistake

oSumAtrIX commented 9 months ago

The padding was kept with full intention because it retains the original logos padding which, when not kept, would be not possible to "guess", whereas removing the padding, as you said, require additional modification regardless, can be done.

The revanced-logo-shape variant padding being removed was a mistake for the same reason.

Ushie commented 9 months ago

When would the original logo padding ever be needed for this variant? because an instance like that sounds like it should be using the full logo.