search

ReVanced / revanced-cli

💻 Command-line application to use ReVanced
https://revanced.app
GNU General Public License v3.0
1.06k stars 164 forks source link

feat: generate patches.json for any supplied patch bundle locally #344

Closed decipher3114 closed 4 hours ago

decipher3114 commented 4 hours ago

Feature description

Add option to generate patches.json file locally

Motivation

This option will benefit third-party patching scripts after the removal of patches.json from releases.

Acknowledgements

oSumAtrIX commented 4 hours ago

You can already list patches via the list-patches subcommand. Anything beyond that is matter outside of the domain of ReVanced CLI

decipher3114 commented 2 hours ago

@oSumAtrIX Getting a well-structured json file would benefit the third-party tools and it totally makes sense to add this to utility subcommand.

oSumAtrIX commented 2 hours ago

As I said, third-party tools have to work with the domain of ReVanced CLI and not the other way around. The list-patches subcommand is for reading the patches from the supplied patch files. Feel free to parse the output to a JSON as part of your domain requirements.

Spacellary commented 1 hour ago

As I said, third-party tools have to work with the domain of ReVanced CLI and not the other way around. The list-patches subcommand is for reading the patches from the supplied patch files. Feel free to parse the output to a JSON as part of your domain requirements.

I hardly oppose this approach, the end result is that this just slows downs and adds complications for workflows where this wasn't the case before. It's a bit rough of a dismissal, I would really hope for a reconsideration on this.

oSumAtrIX commented 1 hour ago

ReVanced CLI is not a means to use in a workflow. This is your domain you are trying to fit in ReVanced's which you will have to solve on your own basis.

decipher3114 commented 1 hour ago

@oSumAtrIX Any CLI tool is meant to be used in a workflow, popularly known as "Shell Scripts". It is totally understandable if you feel lazy to implement it, but the reason is definitely not valid.

oSumAtrIX commented 1 hour ago

This is not a matter of laziness. At most its one on your end to parse the output to JSON as part of your domain requirements. You can use it in a workflow, but you will have to work with the domain of ReVanced CLI. I have been clear multiple times now.