search

ReVanced / revanced-helper

🤖 NLP backed bots assisting ReVanced
https://revanced.app
GNU General Public License v3.0
20 stars 8 forks source link

fix: exile command does not transfer messages correctly #22

Closed oSumAtrIX closed 2 months ago

oSumAtrIX commented 1 year ago

Issue

Images or attachments are not logged in the configured channel when using the command, the original message is not deleted.

Solution

Also consider moving attachments

reisxd commented 1 year ago

This would require to download the images or attachments and store it then send it, if we were to delete the orginal message.

Also a reminder, you can only set a single image for embeds. And also no videos for embeds. This'd break "consistency" with the other bot.

oSumAtrIX commented 1 year ago

This would require to download the images or attachments and store it then send it, if we were to delete the orginal message.

Yes, the images will eventually be inaccessible (after a couple of days). If that is a problem, you must download and upload the attachments to the new message.

Also a reminder, you can only set a single image for embeds

Multiple solutions are available online, you can otherwise attach them to the message regularly. Same for videos, no consistency problem is caused here.

reisxd commented 1 year ago

Can there be a field in the embed where all of the attachments links are in there? Like This:

Restricted to ... Attachments Image 1 Image 2 Video 1

Orginal Message hwo to get peevanc

oSumAtrIX commented 1 year ago

Discord eventually restricts access to deleted attachments if the original message is deleted. Also the links wouldn't embed, I think reuploading is necessary for that reason, but it's not really efficient

reisxd commented 1 year ago

Reuploading them could take a long time depending on what the member has posted. Also, there's 25MiB file size for uploading content. Which means that Nitro users could upload a bigger content and the bot could not transfer it, unless it gets splitted (which requires more code and more time to transfer the message).

oSumAtrIX commented 1 year ago

Discord eventually restricts access to deleted attachments if the original message is deleted.

A solution for this should be proposed then. If the bot fails to upload an attachment, link it, otherwise upload it.

PalmDevs commented 2 months ago

Closing as it is tied to #19