ReVanced / revanced-library

📚 Library containing common utilities for ReVanced
https://revanced.app
GNU General Public License v3.0
43 stars 11 forks source link

feat: release advanced patch option types #26

Open Ushie opened 12 months ago

Ushie commented 12 months ago

Feature description

Introduce Patch Option Types such as Color, which extend on ReVanced Patcher types

Motivation

The ability to use the best-fitting UI for patch options in GUI frontends, while keeping only the necessary types in ReVanced Patcher which has refused to implement these types

Additional context

Perhaps this can be moved to ReVanced Library

Acknowledgements

oSumAtrIX commented 12 months ago

The option types should be structured in it's own Gradle subproject. The subproject is to be then released as a maven package. Patches then have to shade the classes, otherwise they will not work outside of ReVanced Manager because the types would be missing

Ushie commented 10 months ago

This can be moved to the ReVanced Library repository @oSumAtrIX

oSumAtrIX commented 10 months ago

Please open a new issue, this one specifically requests ReVanced Manager patch options and not general advanced types

Ushie commented 10 months ago

No longer an issue, solved

oSumAtrIX commented 10 months ago

Which abstract types are needed?

Ushie commented 10 months ago

Those are the ones I can state of the top of my head, @PalmDevs may have more to add

oSumAtrIX commented 10 months ago

Former 3 will abstract String but former 2 can abstract File. For the last one, decimal and integral numbers are supported as primitive types already.

PalmDevs commented 10 months ago

Also include resource name which will abstract String. Eg. @android:color/black.