False toast when updating Manager

KobeW50 commented 1 year ago

Bug description

When the manager downloads the update, it sends a toast saying that it is "installing update..." which is misleading. The user still needs to accept the prompt from the package installer. An appropriate toast would be "Ready to install update" or "Successfully downloaded update"

https://github.com/ReVanced/revanced-manager/assets/84587632/5ffecb59-1439-4745-ac0f-85b5c4a5ba8f

Version of ReVanced Manager and version & name of application you tried to patch

1.10.1

Installation type

None

Device logs

NA

Patcher logs

No response

Acknowledgements

[X] This request is not a duplicate of an existing issue.
[X] I have chosen an appropriate title.
[X] All requested information has been provided properly.
[X] The issue is solely related to the ReVanced Manager

KobeW50 commented 1 year ago

There is also a minor bug that when the update is already downloaded and you press the 'Update' button, a toast will say "Downloading update..." even though the update is already downloaded.

https://github.com/ReVanced/revanced-manager/assets/84587632/96f0767a-3263-4cd1-a114-54e7de169421

I can open a new issue for this if needed.

oSumAtrIX commented 3 months ago

Is this issue still present?

KobeW50 commented 3 months ago

Yes, both. (Tested with 1.20.0)

ReVanced / revanced-manager