feat: Preview patch list before selecting application

ReVanced / revanced-manager

💊 Application to use ReVanced on Android

https://revanced.app

GNU General Public License v3.0

18.24k stars 748 forks source link

feat: Preview patch list before selecting application #1418

Open KobeW50 opened 1 year ago

KobeW50 commented 1 year ago

Feature description

Allow the user to see the list of patches for an app without needing to have a non-split app installed.

Screenshot_20231023_101858_ReVanced Manager

(This demonstration above is a terrible design. A better one may be to add a new line in the card which will have the amount of patches, and then that can be clickable.

photostudio_1698071671601

Edit: Another possible design is to give the option when the user tries selecting the app card.

SmartSelect_20231023_143643_ReVanced Manager.jpg

A new popup would need to be made for apps that arent installed.

Motivation

The user should not need to go to revanced.app/patches to see what patches are available for an app that is installed as a split APK or not installed on their device.

Additional context

No response

Acknowledgements

[X] This request is not a duplicate of an existing issue.
[X] I have chosen an appropriate title.
[X] All requested information has been provided properly.
[X] The issue is solely related to the ReVanced Manager

oSumAtrIX commented 1 year ago

The patch selector view model can include a readOnly boolean for that.

KobeW50 commented 1 year ago

I guess if the app is installed and the manager has root perms or it isnt a split apk then when the user goes to see the patches preview they should just be taken straight to the patch selection menu without it being read-only.

Also, when it is in read-only mode, the checkbox and buffer on the patch cards can be removed

SmartSelect_20231023_111944_ReVanced Manager.jpg

Edit: Actually, perhaps the full functionality of the patch selection menu should be kept and the user will be allowed to save the patch selection and options for that app (even though it cant be patched currently)

And when the user presses 'Done' after selecting the patches they should ofc be brought back to the application selection screen.

oSumAtrIX commented 1 year ago

they should just be taken straight to the patch selection menu without it being read-only.

This would introduce a new flow of action. Usually, you select an app, which brings you back to the patcher screen, and then you select the patches. Here, it would skip bringing you back to the patcher screen, which is inconsistent in behavior to the current flow of action. So either you display the patches screen readonly with the option to go back to the app selector screen, or you change the flow from "select app -> go back -> select patches" to "select app -> select patches" everywhere.