ReVanced / revanced-manager

💊 Application to use ReVanced on Android
https://revanced.app
GNU General Public License v3.0
17.94k stars 737 forks source link

Exported patch logs show bugged patch selection #1531

Closed KobeW50 closed 10 months ago

KobeW50 commented 11 months ago

Bug description

I've noticed 2 issues with the new patch logs that are copied to clipboard.

A) The log lists all of the included patched in the Patches removed: field. (In the logs below, i added a line-break before this field so it is easier to find)

B) The log lists all of the included patches in the Patches added: field, even though there were only default patches included. (Tbh i'm not sure if this one is a bug)

Steps to reproduce

  1. Clear the app data of the Manager
  2. Patch the suggested YT version with the 61 default patches (without changing any of the settings in the Manager).
  3. Export and inspect the patch log.

Bug A and B do not always occur. Once bug A occurs, the only way it can go away is by clearing the app data, which may temporarily fix the issue. I'm not too sure about when bug B occurs, or if it is related to bug A.

https://github.com/ReVanced/revanced-manager/assets/84587632/0f9042a1-cabc-42c1-87a9-661dfe1f249e

Version of ReVanced Manager and version & name of application you tried to patch

1.17.0. YT 18.45.41

Installation type

None

Device logs

.

Patcher logs

- Device Info
ReVanced Manager: 1.17.0
Build: release
Model: SM-S906U1
Android version: 13
Supported architectures: arm64-v8a, armeabi-v7a, armeabi
Root permissions: No

- Patch Info
App: com.google.android.youtube v18.45.41
Patches version: v2.201.0
Patches added: Alternative thumbnails, Always autorepeat, Announcements, Bypass URL redirects, Client spoof, Comments, Copy video url, Custom player overlay opacity, Disable auto captions, Disable fullscreen ambient mode, Disable player popup panels, Disable precise seeking gesture, Disable resuming Shorts on startup, Disable rolling number animations, Disable suggested video end screen, Disable zoom haptics, Enable debugging, Enable slide to seek, Enable tablet layout, External downloads, HDR auto brightness, Hide 'Load more' button, Hide Shorts components, Hide ads, Hide album cards, Hide autoplay button, Hide breaking news shelf, Hide captions button, Hide cast button, Hide crowdfunding box, Hide email address, Hide endscreen cards, Hide filter bar, Hide floating microphone button, Hide info cards, Hide layout components, Hide player buttons, Hide seekbar, Hide timestamp, Hide video action buttons, Minimized playback, Navigation buttons, Open links externally, Playback speed, Player flyout menu, Premium heading [Use premium heading: true], Remember video quality, Remove tracking query parameter, Restore old seekbar thumbnails, Restore old video quality menu, Return YouTube Dislike, Seekbar tapping, SponsorBlock, Spoof app version, Spoof device dimensions, Swipe controls, Tablet mini player, Theme [Dark theme background color: @android:color/black, Light theme background color: @android:color/white], Vanced MicroG support, Video ads, Wide searchbar

Patches removed: Hide ads, Video ads, Copy video url, External downloads, Disable precise seeking gesture, Seekbar tapping, Enable slide to seek, Swipe controls, Disable auto captions, Premium heading [Use premium heading: true], Hide video action buttons, Hide autoplay button, Hide captions button, Hide cast button, Navigation buttons, Hide player buttons, Hide album cards, Hide breaking news shelf, Comments, Hide crowdfunding box, Hide endscreen cards, Hide filter bar, Hide floating microphone button, Disable fullscreen ambient mode, Hide layout components, Hide info cards, Hide 'Load more' button, Hide email address, Player flyout menu, Disable rolling number animations, Hide seekbar, Hide Shorts components, Disable suggested video end screen, Hide timestamp, Disable player popup panels, Custom player overlay opacity, Return YouTube Dislike, Wide searchbar, Restore old seekbar thumbnails, SponsorBlock, Spoof app version, Disable resuming Shorts on startup, Enable tablet layout, Tablet mini player, Theme [Dark theme background color: @android:color/black, Light theme background color: @android:color/white], Alternative thumbnails, Announcements, Always autorepeat, Enable debugging, Spoof device dimensions, Client spoof, Bypass URL redirects, Vanced MicroG support, Minimized playback, Remove tracking query parameter, Disable zoom haptics, HDR auto brightness, Remember video quality, Playback speed, Restore old video quality menu, Open links externally
Options changed: None

- Settings
Allow changing patch selection: false
Version compatibility check: true
Show universal patches: false
Patches source: revanced/revanced-patches
Integration source: revanced/revanced-integrations

- Logs
Copying APK
Reading APK
Decoding app manifest
Loading patches
Merging integrations
Deleting existing resource cache directory
Decoding resources
Executing patches
Applied 62 patches
Compiling patched dex files
Compiled 8 dex files
Compiling modified resources
Signing APK
Patched

Acknowledgements

KobeW50 commented 11 months ago

I tested by patching YT and YTM 15 times (and changing something each time) and recorded each log. Once after clearing the app data and using the default YT patches, I got this log, which is how I imagine it is supposed to be when you only use the default patches. (Although it should really say Patches added: Default)

- Patch Info
App: com.google.android.youtube v18.45.41
Patches version: v2.201.0
Patches added: None
Patches removed: None
Options changed: None

- Settings
Allow changing patch selection: false
Version compatibility check: true
Show universal patches: false
Patches source: revanced/revanced-patches
Integration source: revanced/revanced-integrations

- Logs
Copying APK
Reading APK
Decoding app manifest
Loading patches
Merging integrations
Deleting existing resource cache directory
Decoding resources
Executing patches
Applied 62 patches
Compiling patched dex files
Compiled 8 dex files
Compiling modified resources
Signing APK
Patched