Open ILoveOpenSourceApplications opened 11 months ago
@Domenic-MZS, maybe you can look into this one?
Sorry for the delay, @ILoveOpenSourceApplications. I've been a bit busy lately.
Yup, I'd like to try this one. Let me handle this issue.
TL;DR The issue seems to be with the current layout, where the refresh indicator wraps the AppBar and Content, causing the subsequent overscroll to show the indicator over the scrollable app bar and content.
It should be relatively easy to fix; it just needs a gap on the edge property (from which starts showing the refresh indicator) or by changing the layout.
Feature description
When refreshing
Dashboard
, the refresh animation that shows up is an incomplete circle animation instead of the traditional circling cycle animation on every other apps. (Don't judge me for phrasing it this way.)What ReVanced Manager does:
https://github.com/ReVanced/revanced-manager/assets/117499019/b3601f3e-d398-4cf9-96e0-965141a7fbd8
What it should be doing:
https://github.com/ReVanced/revanced-manager/assets/117499019/d8a8207f-e3e0-4345-a464-f486c29fe7bc
Also, the refresh icon starts showing up all the way from the notification shade instead of showing up within the manager. It should start from the point in the
Dashboard
where the padding is when scrolling down.Without scrolling:
When scrolled down a bit:
The refresh icon should start after the padded area of
Dashboard
, like it's coming from underneath the padded area.Motivation
I checked out the examples provided in the repository and
MaterialClassicHeader
seems to be the one which was implemented in ReVanced Manager (or looks like what was intended). Correct me if I'm wrong. P.S: Attaching the gif for further clarityAdditional context
No response
Acknowledgements