ReVanced / revanced-manager

💊 Application to use ReVanced on Android
https://revanced.app
GNU General Public License v3.0
18.24k stars 748 forks source link

feat: Don't show "Disable auto updates" warning every time #1628

Open ILoveOpenSourceApplications opened 10 months ago

ILoveOpenSourceApplications commented 10 months ago

Bug description

When the user updates the app via revanced manager, even if they have done it before, they are still shown a warning screen saying to disable auto updates. I understand that this is significant for rooted users as the play store will try to update YouTube if it's not disabled. But is there any significance for this warning to be shown to non-rooted users? And if there is, I believe that it should only be shown once and once the user accepts the warning, it should not be shown to the user everytime they try to patch an app.

The warning message: Screenshot_20240109_151119_ReVanced Manager

Version of ReVanced Manager and version & name of application you tried to patch

ReVanced Manager 1.18.0

Installation type

Non-root

Device logs

Nil

Patcher logs

No response

Acknowledgements

GlitchyPie commented 10 months ago

Edit: turns out I've not actually run a patch on 1.18.0 that's why I've not encountered this....

~I've never seen this warning, what are the conditions required for it to even show in the first place.~

~Also on 1.18.0~

~Non-root user.~

oSumAtrIX commented 10 months ago

Yes, non-rooted users are significant. Your device may attempt to update the patched app by matching the package name of the patched app to a database. The warning should not be shown once; otherwise you'll forget it. At max, it can be a popup with a checkmark to not show again.

ILoveOpenSourceApplications commented 10 months ago

But isn't the package name changed by default for non-rooted users due to the GMS Core patch?

Edit: Yes, there are other apps which doesn't have a changed package name and for those it's significant. But, if that's the case then it should be made per app basis or dependent to the patches selected. Given if microg or gms core patches are selected then there's no significance to this warning.

Ushie commented 10 months ago

ReVanced Manager isn't aware of whether or not the new package name exists as an entry in the PlayStore

ILoveOpenSourceApplications commented 10 months ago

At max, it can be a popup with a checkmark to not show again.

I can agree with this as a solution. The user can agree to the statement and produce a pop-up saying never to show again after agreeing.

Qaz-6 commented 10 months ago

I can't update the app because of this warning.In the latest version, when you click the install button, it says that the installation has been canceled.Apk export button not working