search

ReVanced / revanced-manager

💊 Application to use ReVanced on Android
https://revanced.app
GNU General Public License v3.0
16.49k stars 705 forks source link

bug: App Not Drawing Behind Navigation Bar on Patching Screen #1783

Open Dan-Banfield opened 3 months ago

Dan-Banfield commented 3 months ago

Bug description

On the patching screen, it seems the app is not in edge-to-edge mode because it does not draw behind the system navigation bar.

1000020943

Version of ReVanced Manager and version & name of app you are patching

Version 1.19.3 App being patched: any

Installation method

Regular

ReVanced Manager logs

Not relevant.

Patch logs

Not relevant.

Acknowledgements

snehithssv commented 2 weeks ago

So, while on patching screen, the bottom nav-bar should be hidden?? @Dan-Banfield

Dan-Banfield commented 2 weeks ago

So, while on patching screen, the bottom nav-bar should be hidden?? @Dan-Banfield

No, not hidden, just the app should draw behind it in-line for the upcoming mandate in Android 15.

snehithssv commented 2 weeks ago

No, not hidden, just the app should draw behind it in-line for the upcoming mandate in Android 15.

So, app is to be forced to be in edgeToEdge instead of leanBack/immersive.? More like this...?? Screenshot_1718089769

And if yes, should it be this way only in patch screen on for the whole application??

Dan-Banfield commented 2 weeks ago

In the screenshot you provided, the navigation bar at the bottom is still black. Instead, it should be drawn behind. Please see: https://developer.android.com/about/versions/15/behavior-changes-15#:~:text=Edge-to-edge%20enforcement,because%20most%20components%20apply%20insets.

snehithssv commented 2 weeks ago

Thanks a lot for helping me out... @Dan-Banfield projc.webm So, is this the desired functionality?

Dan-Banfield commented 2 weeks ago

Thanks a lot for helping me out... @Dan-Banfield projc.webm So, is this the desired functionality?

Yes, that looks great! Nice job.