bug: Two ways to change version in app info screen

ReVanced / revanced-manager

💊 Application to use ReVanced on Android

https://revanced.app

GNU General Public License v3.0

17.6k stars 727 forks source link

bug: Two ways to change version in app info screen #1994

Closed oSumAtrIX closed 1 month ago

oSumAtrIX commented 3 months ago

Bug description

The correct way to "Undo" a choice is to "Go back" to the previous screen. Having a separate setting to change the version doesn't make sense in the sense of a progression:

Acknowledgements

[X] This issue is not a duplicate of an existing bug report.
[X] I have chosen an appropriate title.
[X] All requested information has been provided properly.
[X] The bug is only related to ReVanced Manager

Ushie commented 3 months ago

Perhaps this screen should be removed, it serves no purpose, instead the patch selector screen should take it's spot instead and from there we can arrive at the patching process

oSumAtrIX commented 3 months ago

Makes sense, although having an "Overview" before starting to patch is good. Mabe after the patch selector?

Ushie commented 3 months ago

Oh, I remember why we didn't want to throw the user into the patches screen

The user is expected to use the default selection of patches, making the patch selection page a forced step in the flow may cause the user to meddle when they don't really know what they're doing, those who want to change things will know how to, without adding an unnecessary step to the masses and making them think they have to do something

oSumAtrIX commented 3 months ago

A recommended Skip (Fab) button can be added

Axelen123 commented 2 months ago

This issue will be dealt with by the downloader plugin branch