feat: Include supported architecture in APK search query

ReVanced / revanced-manager

💊 Application to use ReVanced on Android

https://revanced.app

GNU General Public License v3.0

17.28k stars 722 forks source link

feat: Include supported architecture in APK search query #2042

Open KobeW50 opened 1 month ago

KobeW50 commented 1 month ago

Feature description

When tapping on the suggested version to start a search in a browser, the query should include the supported architecture of the device.

Example: com.google.android.apps.youtube.music apk version 7.03.52 arm64-v8a

If there are multiple architectures supported by the device, the Manager should only query for the most modern arch (arm64-v8a > armeabi-v7a, and x86_64 > x86).

Motivation

This will help users avoid choosing an APK that is not compatible with their device.

Acknowledgements

[X] This issue is not a duplicate of an existing feature request.
[X] I have chosen an appropriate title.
[X] The feature request is only related to ReVanced Manager

KobeW50 commented 1 month ago

Btw, I intended this feature request for the current ReVanced Manager (I haven't tried the compose Manager). But if it is needed for compose Manager then sure

validcube commented 1 month ago

Btw, I intended this feature request for the current ReVanced Manager (I haven't tried the compose Manager). But if it is needed for compose Manager then sure

👋 Hello, @KobeW50!

We have shifted focus to Compose variant of the ReVanced Manager, so your issue is delegated to said variant. Nonetheless thanks for the suggestion!

(That being said, Flutter variant will still be supported until Compose release, we could potentially backported the change to here too!)

For me I (personally) expect it to release later this year, so keep a eye out for pre-release/testing build. 👀

validcube commented 1 month ago

👋 Hello @KobeW50!

Thanks for the feature request, this is added in ReVanced Manager Flutter v1.21.0; this issue will not be closed as it is now awaiting backport to Compose.

If the implementation of the feature wasn't up to your satisfaction, feels free to reopen!

KobeW50 commented 1 month ago

Thank you very much! 🙏

This issue will not be closed as it is now awaiting backport to Compose.

It says that the issue will be closed when dev is merged to main. Will this be when compose is ready?

validcube commented 1 month ago

Whoops, (It's almost 2 am, forgive me)

KobeW50 commented 1 month ago

Np. Also maybe add the compose manager issue label