ReVanced / revanced-manager

💊 Application to use ReVanced on Android
https://revanced.app
GNU General Public License v3.0
17.95k stars 740 forks source link

feat: Add confirm dialogs when toggling dangerous settings #2055

Open oSumAtrIX opened 3 months ago

oSumAtrIX commented 3 months ago

Feature description

Right now safeguards for example can be simply toggled (even accidentally):

image

When toggling them yet another warning should be shown to clarify why it is unsuggested.

Motivation

The user might toggle them without knowing that they shouldnt.

Acknowledgements

TheAabedKhan commented 3 months ago

Should this be the expected behavior?

https://github.com/user-attachments/assets/8f3df7c0-bde5-4190-9e56-ee3e1474ffa6

Axelen123 commented 3 months ago

"Require suggested app version" is on by default, so the dialog should be shown when it goes from true -> false

TheAabedKhan commented 3 months ago

Fixed✅

Ushie commented 3 months ago

Open a PR so we can review