ReVanced / revanced-manager

💊 Application to use ReVanced on Android
https://revanced.app
GNU General Public License v3.0
17.92k stars 737 forks source link

feat: Show warning dialog if any patch fails #2246

Open LisoUseInAIKyrios opened 2 weeks ago

LisoUseInAIKyrios commented 2 weeks ago

Feature description

When users patch the wrong version of an app, or they configure a patch option wrong, or something else goes wrong during patching, then Manager should show a dialog warning that patching failed and the app may not install or work correctly.

I'm not sure how Manager can detect a patching failure, but I would speculate that patcher would need to return a value indicating if all patches completed successfully or if any failed.

Motivation

Users do not always understand what a patch exception stack trace is or why that means a failure, and it leads to troubleshooting hassles for others. Issues such as GmsCore support failing to patch, then installation fails because the package name was not changed and the install is trying to update the stock YouTube app.

Situations like this (GmsCore support failed to patch and the user did not notice): Image

Acknowledgements

oSumAtrIX commented 2 weeks ago

There are two types of exceptions. Exceptions raised by patches or exceptions raised from elsewhere, such as installing, OOM, etc. Patcher yields a patch result for every executed patch, so the Manager can check for that and display a warning that mentions if any patch has failed. Pairing it with information such as wether a suggested version was patched and other meta info would be useful

KobeW50 commented 2 weeks ago

the Manager can check for that and display a warning that mentions if any patch has failed. Pairing it with information such as wether a suggested version was patched and other meta info would be useful

Perhaps the 'Copy log' button can be on the warning popup as well.