bug: new revanced app installing as a separate app (Debug signed)

ReVanced / revanced-manager

💊 Application to use ReVanced on Android

https://revanced.app

GNU General Public License v3.0

18.24k stars 748 forks source link

bug: new revanced app installing as a separate app (Debug signed) #2299

Closed Shazzkid closed 6 days ago

Shazzkid commented 6 days ago

Bug description

When updating the app through the revanced app, it is installing a separate revanced app (Debug signed)

Version of ReVanced Manager and version & name of app you are patching

1.23.0

Installation method

None

ReVanced Manager logs

N/a

Patch logs

Acknowledgements

[x] I have checked all open and closed bug reports and this is not a duplicate.
[x] I have chosen an appropriate title.
[x] All requested information has been provided properly.
[x] The bug is only related to ReVanced Manager.

oSumAtrIX commented 6 days ago

Should be just a visual bug.

Shazzkid commented 6 days ago

Should be just a visual bug.

Both might be working fine but i now have 2 revanced apps, the original one, and a (Debug signed) version.

oSumAtrIX commented 6 days ago

I've pulled that release so that it wont get downloaded for now until the hotfix is pushed.

oSumAtrIX commented 6 days ago

Not sure, why but it branches off to debug signed:

rywz commented 6 days ago

I'm not sure if it's intentional or not, but all of the versions after 1.22.1-dev.2 are signed as debug build.

oSumAtrIX commented 6 days ago

Might be fixed with https://github.com/ReVanced/revanced-manager/actions/runs/11766475941/job/32774048116

Shazzkid commented 6 days ago

Might be fixed with https://github.com/ReVanced/revanced-manager/actions/runs/11766475941/job/32774048116

That hasn't fixed it unfortunately, its still Debug signed and installs a separate app.

wolf-yuan-6115 commented 6 days ago

I'm not familiar with Gradle but this doesn't seems right:

https://github.com/ReVanced/revanced-manager/blob/5139873f79fcf6534f197de409202ef25a4fda6d/android/app/build.gradle.kts#L47

oSumAtrIX commented 6 days ago

I am not sure what you are referring to here.

wolf-yuan-6115 commented 6 days ago

I am not sure what you are referring to here.

I've updated the link, it said signedConfigs is debug

oSumAtrIX commented 6 days ago

Yes, but it is overriden by the release profile

wolf-yuan-6115 commented 6 days ago

Aw I see

oSumAtrIX commented 6 days ago

https://github.com/ReVanced/revanced-manager/actions/runs/11766634218 Another shot ;)

Lassie111 commented 6 days ago

Doesn't that last } become part of the filename?

oSumAtrIX commented 6 days ago

Good catch

yonggamer commented 6 days ago

i see this is this by choice?

oSumAtrIX commented 6 days ago

https://github.com/ReVanced/revanced-manager/actions/runs/11766663908 next attempt

Shazzkid commented 6 days ago

https://github.com/ReVanced/revanced-manager/actions/runs/11766663908 next attempt

We have a winner!

yonggamer commented 6 days ago

but it failded with Error: Process completed with exit code 1.

Shazzkid commented 6 days ago

https://github.com/ReVanced/revanced-manager/actions/runs/11766663908 next attempt

Hmm, it has installed correctly, but it won't connect to the API. The Debug version does connect fine, so i think the issue is with this latest release. I've cleared the cache, restarted the app, no difference. Latest version won't connect to API, Debug version does.

oSumAtrIX commented 6 days ago

Can you connect to https://api.revanced.app/v4/patches?

Vucko130 commented 6 days ago

https://github.com/ReVanced/revanced-manager/actions/runs/11766663908 next attempt

Hmm, it has installed correctly, but it won't connect to the API. The Debug version does connect fine, so i think the issue is with this latest release. I've cleared the cache, restarted the app, no difference. Latest version won't connect to API, Debug version does.

It connects. i am patching now.

yonggamer commented 6 days ago

yes but is this name by chioce?

Lassie111 commented 6 days ago

https://github.com/ReVanced/revanced-manager/actions/runs/11766663908 next attempt

Hmm, it has installed correctly, but it won't connect to the API. The Debug version does connect fine, so i think the issue is with this latest release. I've cleared the cache, restarted the app, no difference. Latest version won't connect to API, Debug version does.

Resetting API URL fixed it for me.

Vucko130 commented 6 days ago

yes but is this name by chioce?

download latest one now from github releases.

Shazzkid commented 6 days ago

Can you connect to https://api.revanced.app/v4/patches?

https://api.revanced.app/v4/patches doesn't seem to work, but the Debug version had https://api.revanced.app/v4/ and putting that into the new version DOES work.

Shazzkid commented 6 days ago

https://github.com/ReVanced/revanced-manager/actions/runs/11766663908 next attempt

Hmm, it has installed correctly, but it won't connect to the API. The Debug version does connect fine, so i think the issue is with this latest release. I've cleared the cache, restarted the app, no difference. Latest version won't connect to API, Debug version does.

Resetting API URL fixed it for me.

Yes it seemed that is it automatically using the old API, instead of the new default API. Resetting it to force it to update to the new API works, as did putting it in manually.