search

ReVanced / revanced-manager

💊 Application to use ReVanced on Android
https://revanced.app
GNU General Public License v3.0
18.5k stars 751 forks source link

bug: Suggest version after selection of patches #2310

Open oSumAtrIX opened 2 weeks ago

oSumAtrIX commented 2 weeks ago

Bug description

Currently, the suggested version is listed in the app selector screen. Instead, the flow should be like this:

  1. User opens app selector and selects an app
  2. The patch selector screen opens where the user can select a list of patches. If default is forced, then skip this step
  3. Based on the current selection, the version of the selected app is checked. If it matches, skip this step. If it does not match, show a dialog that shows the suggested version based on that selection and offers to choose the APK from storage. (Since APKs can be split, the dialog should also ask to select from storage due to the app being split too, like it is now)
  4. After that, the user lands back on the patcher screen and can start patching

Motivation

Depending on your patch selection, the suggested version may be different. For example, you select patches that work with any app, and uncheck one that only works on a specific version. ReVanced Manager would suggest that one, even if you don't use the patch.

Acknowledgements

KobeW50 commented 2 weeks ago

The motivation makes sense, but i think this will cause confusion for users, since many people will have different suggested versions.

Furthermore, this may cause users to download more APKs than previously since the suggested version can change just by changing the patch selection

oSumAtrIX commented 2 weeks ago

Users are suggested to use the recommended selection. Those who change it will potentially see a different suggested version based on their selection. The version must be calculated from the selection, not doing it is not an option and a severe problem as seen with the Twitter patches suggesting a version based on a single patch that is disabled by default, but making users download an old version which breaks one of the patches intended for the late versions.

Users don't have to download "more" APKs. You patch once.