feat: Make it clear to the user that some patches can be disabled later

SodaWithoutSparkles commented 2 years ago

Type

Functionality

Issue

Some patches seems that it would disrupt the app too much and the user does not want to incorporate it. But it turns out it is needed then they want it later. E.g. disable auto caption, popup panels, etc.

Feature

Make it clear to user that the patch can be enabled/disabled during runtime so they are not afraid to include it during patch-time

Motivation

The current description provides too little infomation for a educated guess on if the patch supports settings. It also does not provide a recommendation for what should be included. As patching takes way longer time, telling the user that the patch can be disabled during runtime can allow the user to try out new patches without fear, knowing that they could disable it later

Additional context

No response

Acknowledgements

[X] I have searched the existing issues and this is a new and no duplicate or related to another open issue.
[X] I have written a short but informative title.
[X] I filled out all of the requested information in this issue properly.
[X] The issue is related solely to the ReVanced Manager

Aunali321 commented 2 years ago

Not the job of the manager. Patch description are from revanced-patches.

SodaWithoutSparkles commented 2 years ago

Or detect from the patches.json to see if it supports settings. If no, change the text colour to something else. Or if yes, add a icon (maybe a gear icon?) to show that it supports settings. This would be way easier and faster comparing with asking each of the maintainer to change the patch.

Edit: we may check for the dependencies in patches.json for settings, for example, the patch remember quality settings for YT have the following dependencies:

"dependencies":["integrations","video-id-hook","settings"]

As "settings" is a dependencies it should supports configuring, so a gear icon should be shown.

@Aunali321

SodaWithoutSparkles commented 2 years ago

Any opinions? @oSumAtrIX

oSumAtrIX commented 2 years ago

Settings is a specific patch to YouTube, it doesn't make sense to design an architecture just for it for the manager.

SodaWithoutSparkles commented 2 years ago

Understandable. Have a good day!

ReVanced / revanced-manager