ReVanced / revanced-manager

💊 Application to use ReVanced on Android
https://revanced.app
GNU General Public License v3.0
18.05k stars 743 forks source link

New supported v18.08.37 fails when applying patches #806

Closed Sockolet closed 1 year ago

Sockolet commented 1 year ago

Type

Error while running the manager

Bug description

New supported version is v18.08.37, however it fails when compiling patches.

Steps to reproduce

  1. Download supported Youtube apk v18.08.37 (no bundle) from apkmirror
  2. Go to patcher in ReVanced manager and choose the patches you like
  3. It will fail when applying patches

Android version

Android 13

Manager version

Tried with stable v0.0.57 and also with new dev v0.1.1-dev.1. It fails on both.

Target package name

com.google.android.youtube_18.08.37-1536290240_minAPI26(arm64-v8a,armeabi-v7a,x86,x86_64)(nodpi)_apkmirror.com.apk

Target package version.

v18.08.37

Installation type

Non-root

Patches selected.

All of them except: always auto-repeat, change package name, custom video buffer, enable debugging, enable android debugging, export all activities, hide shorts button, predictive back gesture, remove screenshoot restriction and spoof wifi connection.

Device logs (exported using Manager settings).

Can't paste, is too long for the body it says.

Installer logs (exported using Installer menu option) [unneeded if issue is not during patching].

Initializing installer
Creating working directory
Copying original apk
Unpacking input apk
Reading dex files
Decoding AndroidManifest.xml only, because resources are not needed
Merging integrations
Deleting existing resource cache directory
Decoding resources
Applied client-spoof
Failed to apply comments: 'comments' depends on 'comments-resource-patch' but the following error was raised: 'comments-resource-patch' depends on 'settings' but the following error was raised: Failed to resolve ThemeSetterAppFingerprint
Failed to apply copy-video-url: 'copy-video-url' depends on 'copy-video-url-resource' but the following error was raised: 'copy-video-url-resource' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Applied custom-branding
Applied custom-video-speed
Failed to apply disable-auto-captions: 'disable-auto-captions' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Failed to apply disable-fullscreen-panels: 'disable-fullscreen-panels' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Failed to apply disable-player-popup-panels: 'disable-player-popup-panels' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Failed to apply disable-shorts-on-startup: 'disable-shorts-on-startup' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Failed to apply disable-zoom-haptics: 'disable-zoom-haptics' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Failed to apply downloads: 'downloads' depends on 'downloads-resource-patch' but the following error was raised: 'downloads-resource-patch' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Failed to apply enable-wide-searchbar: 'enable-wide-searchbar' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Failed to apply general-ads: 'general-ads' depends on 'GeneralAdsResourcePatch' but the following error was raised: 'GeneralAdsResourcePatch' depends on 'LithoFilterPatch' but the following error was raised: Could not find the method to hook.
Failed to apply hdr-auto-brightness: 'hdr-auto-brightness' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Failed to apply hide-album-cards: 'hide-album-cards' depends on 'hide-album-cards-resource-patch' but the following error was raised: 'hide-album-cards-resource-patch' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Failed to apply hide-artist-card: 'hide-artist-card' depends on 'LithoFilterPatch' but the following error was raised: 'LithoFilterPatch' did not succeed previously
Failed to apply hide-autoplay-button: 'hide-autoplay-button' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Failed to apply hide-breaking-news-shelf: 'hide-breaking-news-shelf' depends on 'breaking-news-shelf-resource-patch' but the following error was raised: 'breaking-news-shelf-resource-patch' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Failed to apply hide-captions-button: 'hide-captions-button' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Failed to apply hide-cast-button: 'hide-cast-button' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Failed to apply hide-create-button: 'hide-create-button' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Failed to apply hide-crowdfunding-box: 'hide-crowdfunding-box' depends on 'crowdfunding-box-resource-patch' but the following error was raised: 'crowdfunding-box-resource-patch' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Failed to apply hide-email-address: 'hide-email-address' depends on 'hide-email-address-resource-patch' but the following error was raised: 'hide-email-address-resource-patch' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Failed to apply hide-endscreen-cards: 'hide-endscreen-cards' depends on 'hide-endscreen-cards-resource-patch' but the following error was raised: 'hide-endscreen-cards-resource-patch' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Failed to apply hide-floating-microphone-button: 'hide-floating-microphone-button' depends on 'HideFloatingMicrophoneButtonResourcePatch' but the following error was raised: 'HideFloatingMicrophoneButtonResourcePatch' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Failed to apply hide-info-cards: 'hide-info-cards' depends on 'HideInfocardsResourcePatch' but the following error was raised: 'HideInfocardsResourcePatch' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Applied hide-my-mix
Failed to apply hide-player-buttons: 'hide-player-buttons' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Failed to apply hide-seekbar: 'hide-seekbar' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Failed to apply hide-timestamp: 'hide-timestamp' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Failed to apply hide-video-action-buttons: 'hide-video-action-buttons' depends on 'LithoFilterPatch' but the following error was raised: 'LithoFilterPatch' did not succeed previously
Failed to apply hide-watch-in-vr: 'hide-watch-in-vr' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Failed to apply hide-watermark: 'hide-watermark' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Failed to apply minimized-playback: 'minimized-playback' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Failed to apply old-quality-layout: 'old-quality-layout' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Applied open-links-externally
Applied premium-heading
Failed to apply remember-playback-speed: 'remember-playback-speed' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Failed to apply remember-video-quality: 'remember-video-quality' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Applied remove-player-button-background
Failed to apply return-youtube-dislike: 'return-youtube-dislike' depends on 'return-youtube-dislike-resource-patch' but the following error was raised: 'return-youtube-dislike-resource-patch' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Failed to apply seekbar-tapping: 'seekbar-tapping' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Failed to apply sponsorblock: 'sponsorblock' depends on 'sponsorblock-resource-patch' but the following error was raised: 'sponsorblock-resource-patch' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Failed to apply spoof-app-version: 'spoof-app-version' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Failed to apply spoof-signature-verification: 'spoof-signature-verification' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Failed to apply swipe-controls: 'swipe-controls' depends on 'swipe-controls-resource-patch' but the following error was raised: 'swipe-controls-resource-patch' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Failed to apply tablet-mini-player: 'tablet-mini-player' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Applied theme
Failed to apply video-ads: 'video-ads' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Repacking patched apk
Compiling resources
Writing modified dex files
Finished!

Screenshots or videos

No response

Solution

No response

Additional context

No response

Acknowledgements

SodaWithoutSparkles commented 1 year ago

I have the same problem. It seems that settings was not applied properly.

Julius8900 commented 1 year ago

Same issue here

HazardEST commented 1 year ago

same here

ShoXyy commented 1 year ago

I get this error "App not installed as package conflicts with an existing package." after running patch update installer Screenshot_20230421_133129_Package installer

LeQiu77 commented 1 year ago

having the same problem.

SodaWithoutSparkles commented 1 year ago

It seems that there are too many "same problem here".

If you have the same problem and cannot provide additional information, react 👍 to the first comment by Sockolet (the top one). You could do so by pressing the 🙂 button.

If you comment here, some people would recieve a notification. Commenting "I have the same issue" does not help. To reduce spam, please use reactions instead.

If you want to get updates on this issue, you could do so by subscribing to this issue instead of commenting.

It should be on the sidebar or at the bottom of the page if you are on mobile. If you are on the github mobile app, it is in the three-dots menu on the top right next to the share button.

Image of the subscribe button

seckingyo commented 1 year ago

same error recommended patches are failed to apply need fix asap

SodaWithoutSparkles commented 1 year ago

What is the last known working version? Starting from the last stable as of 04-14 might be a good start, but I did not have my computer on hand so I cannot use cli to do version pinning.

RV manager needs the ability to version-pin and use unstable integration/patches.

el-chazmo commented 1 year ago

What is the last known working version? Starting from the last stable as of 04-14 might be a good start, but I did not have my computer on hand so I cannot use cli to do version pinning.

RV manager needs the ability to version-pin and use unstable integration/patches.

I'm on v18.05.40

SodaWithoutSparkles commented 1 year ago

I'm on v18.05.40

@el-chazmo Thanks. Patch version and integration version when patching please?

el-chazmo commented 1 year ago

I'm on v18.05.40

@el-chazmo Thanks. Patch version and integration version when patching

I'll be honest... Not sure what you mean. But This is my log

Initializing installer Creating working directory Copying original apk Unpacking input apk Reading dex files Decoding AndroidManifest.xml only, because resources are not needed Merging integrations Deleting existing resource cache directory Decoding resources Applied always-autorepeat Applied client-spoof Applied comments Applied copy-video-url Applied custom-branding Applied custom-video-speed Applied disable-auto-captions Applied disable-fullscreen-panels Applied disable-player-popup-panels Applied disable-shorts-on-startup Applied disable-zoom-haptics Applied downloads Applied enable-wide-searchbar Applied general-ads Applied hdr-auto-brightness Applied hide-album-cards Applied hide-artist-card Applied hide-autoplay-button Applied hide-breaking-news-shelf Applied hide-captions-button Applied hide-cast-button Applied hide-create-button Applied hide-crowdfunding-box Applied hide-email-address Applied hide-endscreen-cards Applied hide-floating-microphone-button Applied hide-info-cards Applied hide-my-mix Applied hide-player-buttons Applied hide-seekbar Applied hide-shorts-button Applied hide-timestamp Applied hide-video-action-buttons Applied hide-watch-in-vr Applied hide-watermark Applied minimized-playback Applied old-quality-layout Applied open-links-externally Applied premium-heading Applied remove-player-button-background Applied seekbar-tapping Applied spoof-app-version Applied spoof-signature-verification Applied swipe-controls Applied theme Applied video-ads Repacking patched apk Compiling resources Writing modified dex files Finished!

Rycia commented 1 year ago

The apk fails to install for me.

SodaWithoutSparkles commented 1 year ago

So it's youtube's modifying the signature then.

@Rycia Go to the reddit fourm r/revancedapp for help. APK not installing is not the topic here.

Rycia commented 1 year ago

The apk fails to install for me.

So it's youtube's modifying the signature then.

@Rycia Go to the reddit fourm r/revancedapp for help. APK not installing is not the topic here.

Well, I'm getting these exact errors. I was just adding that they'd result in making the apk not installable.

seckingyo commented 1 year ago

any fix yet for the issue? i guess google team is going through this repository it would better if hidden from them

reisxd commented 1 year ago

any fix yet for the issue? i guess google team is going through this repository it would better if hidden from them

bruh

Sockolet commented 1 year ago

same error recommended patches are failed to apply need fix asap

Lol ASAP Don't worry. Everybody will stop whatever their doing in their real life to solve this annonying bug for you.

oSumAtrIX commented 1 year ago

The release has been released wrongly and already removed.

SodaWithoutSparkles commented 1 year ago

The release has been released wrongly and already removed.

What release? Manager or patches?

Sockolet commented 1 year ago

Ok now it is patching fine. However the resultant apk only shows "Update" and not "Install" when trying to install it. I've removed the previous ReVanced app, so there's nothing to Update... Not sure what's happening.

oSumAtrIX commented 1 year ago

This is an issue with the phone; try unlatching it from the main menu of ReVanced Manager.

SodaWithoutSparkles commented 1 year ago

Patch 18.15.40 instead. @abubakrsiddq

SodaWithoutSparkles commented 1 year ago

Patch 18.15.40 instead. @abubakrsiddq

I think this is a Samsung phone issue found below link, hope it helps others too https://www.reddit.com/r/revancedapp/comments/12kq0rr/walkthrough_for_samsung_users/?utm_source=share&utm_medium=android_app&utm_name=androidcss&utm_term=1&utm_content=share_button

Dont follow that. That one's outdated and contains wrong information. Follow this instead: https://www.reddit.com/r/revancedapp/comments/xlcny9/revanced_manager_guide_for_dummies/

If you have any issue, nuke everything and start from scratch. Remove revanced manager, revanced youtube. Then follow the guide again