feat(YouTube): Loop video overlay button toggle

AmpersandersCos commented 1 year ago

Application

ReVanced Youtube App

Issue

Repeat Button Toggle is in a sub menu that requires at least 2 clicks to reach.

Patch

A simple optional button that can be added or removed to allow the person to choose to repeat said video without having to click into a submenu every single time.

Motivation

This would save people time as well as make menu-ing less of a hassle. The auto-replay feature is already something that can be turned on in the ReVanced misc section setting but that amount of menuing is ridiculous. Even having to click the side setting icon to turn on or off "loop video" is a hassle. A simple "repeat" icon that can be pressed on or off would be great to have and benefit everyone who listens to music and maybe just wants to listen to a specific song on repeat in their playlist.

Acknowledgements

[X] I have searched the existing issues and this is a new and no duplicate or related to another open issue.
[X] I have written a short but informative title.
[X] I filled out all of the requested information in this issue properly.

AmpersandersCos commented 1 year ago

Screenshot_20230413_005649

Ideal placement could be somewhere here, sort of how the old Vanced had this option as well as a togglable option in the misc menu of Vanced.

whc2001 commented 1 year ago

Actually is the auto repeat feature even working for you? I remember on Vanced this feature worked flawlessly and with shortcut button on video OSD, but with ReVanced this feature doesn't work at all on my end.

AmpersandersCos commented 1 year ago

Actually is the auto repeat feature even working for you? I remember on Vanced this feature worked flawlessly and with shortcut button on video OSD, but with ReVanced this feature doesn't work at all on my end.

I have gotten it to work if it is not in a "playlist mode" but itxs is just mega annoying to have to toggle through so many sub menus just to activate this featre. A simple on-screen button like prior Vanced would be best to have.

whc2001 commented 1 year ago

After reinstalling the Magisk module seems like it's working. However I totally agree that a button on the OSD would be very convenient since the repeat status is not retained for every video.

Lxtharia commented 1 month ago

+1, I remembered there used to be an option to add a toggle loop button, but it now seems to be missing. Would love to see it again, just like you can add/remove "copy video url at time" buttons

ReVanced / revanced-patches