ReVanced / revanced-patches

🧩 Patches for ReVanced
https://revanced.app
GNU General Public License v3.0
2.23k stars 260 forks source link

feat(YouTube): Show subtitles / captions in PiP mode & tablet mini player #1164

Closed castdrian closed 3 months ago

castdrian commented 1 year ago

Application

YouTube

Issue

YouTube subtitles aren't displayed in PiP mode/tablet miniplayer because they're some screen overlay that just gets disabled

Patch

Ideally the captions would be visible in PiP mode and tablet miniplayer

Motivation

It seems reasonable that captions shouldn't disappear, whilst you're watching something

Acknowledgements

oSumAtrIX commented 1 year ago

Captions would block the entire view to videos. This patch is not feasible properly, likely why YouTube also did not implement it natively.

castdrian commented 1 year ago

I would like to mention that Netflix has this working perfectly fine by just scaling down the subtitles appropriately with the PiP window, but alas this can stay closed as it's probably too challenging to implement either way.

oSumAtrIX commented 1 year ago

Doesn't look too small, i imagined it worse. This request would need a patch to disable the behavior of turning off subtitles when going into PiP.

pritkr commented 1 year ago

Mpv shows subtitles in a good way in android for reference- Screenshot_20230416-095838_One UI Home Screenshot_20230416-095758_One UI Home ![Screenshot_20230416-095838_One UI Home] I wanted to see this feature in youtube for a long time

oSumAtrIX commented 3 months ago

Over time, a lot of feature requests have been made, which is why I am closing some according to the contribution guidelines:

Requests can be accepted or rejected at the discretion of maintainers of ReVanced Patches

This feature request has been closed for one or more of the following reasons:

Regardless, anyone who comes across this feature request can PR it. Thanks for the feature request!