bug(youtube/sponsorblock): autoplay button in wrong location - Githubissues

ReVanced / revanced-patches

🧩 Patches for ReVanced

https://revanced.app

GNU General Public License v3.0

2.04k stars 239 forks source link

bug(youtube/sponsorblock): autoplay button in wrong location #1176

Closed InakiArzalluz closed 1 year ago

InakiArzalluz commented 1 year ago

Type

Cosmetic

Bug description

The autoplay button is overlapping with the config button inside the player, rendering the config button unclickable. It's present in both portrait and landscape mode.

Steps to reproduce

Using release v2.168.0-dev.6 or newer:

Patch Youtube including 'sponsorblock' and 'microg-support'.
Open a video.
Try to change the video resolution.

autoplay and config buttons are overlapping.

Relevant log output

Screenshots or videos

20230406_023020

Solution

No response

Additional context

Tested only under Android 8.1.0 (Samsung Experience 9.5), non-root

The bug is present if:

Sponsoblock patch was applied, even if it's currently disabled.
The bug isn't present if:
- sponsorblock patch wasn't applied
- release v2.168.0-dev.4 (or older) was used to patch youtube

Acknowledgements

[X] I have searched the existing issues and this is a new and no duplicate or related to another open issue.
[X] I have written a short but informative title.
[X] I filled out all of the requested information in this issue properly.

oSumAtrIX commented 1 year ago

Is YouTube not > Android 8

InakiArzalluz commented 1 year ago

No, youtube is >= 8.0 (At least v18.05.40 and v18.08.37)

oSumAtrIX commented 1 year ago

Decrease font size/increase display size check if that does anything.

LisoUseInAIKyrios commented 1 year ago

How is the autoplay button shown? I have not seen that before.

InakiArzalluz commented 1 year ago

How is the autoplay button shown? I have not seen that before.

This is how it looks when release v2.168.0-dev.4 (or older) is used. 20230406_023037

LisoUseInAIKyrios commented 1 year ago

I was able to reproduce. I should be simple to figure out a fix.

oSumAtrIX commented 1 year ago

Is this issue regarding the latest dev releases? The SponsorBlock icon is added through a resource patch.

LisoUseInAIKyrios commented 1 year ago

Is this issue regarding the latest dev releases?

Yes

oSumAtrIX commented 1 year ago

I am unsure how this can happen, adding the button happens by adding it in a XML file where you specify to which existing button it should align to from what direction.

LisoUseInAIKyrios commented 1 year ago

It must be something in the latest sponsorblock refactoring (dev release 6). I will look into this and figure out what's wrong.

InakiArzalluz commented 1 year ago

Decrease font size/increase display size check if that does anything.

Just checked that, and they still overlap regardless of the display/font size.

LisoUseInAIKyrios commented 1 year ago

For now, enable hide-autoplay-button, or patch with dev4 or older.

LisoUseInAIKyrios commented 1 year ago

fixed. I would link the PR, but for some reason it only lets me link to branches.