search

ReVanced / revanced-patches

🧩 Patches for ReVanced
https://revanced.app
GNU General Public License v3.0
2.37k stars 272 forks source link

bug(youtube/return-youtube-dislike): dislikes disappear after scrolling #1187

Closed LisoUseInAIKyrios closed 1 year ago

LisoUseInAIKyrios commented 1 year ago

Type

Cosmetic

Bug description

If the like/dislike segmented view is scrolled off screen, and then scrolled back onto screen, the dislikes are not shown.

Steps to reproduce

Using latest dev release:

  1. enable ReturnYouTubeDislike
  2. open a video
  3. scroll down the comments section (so the like/dislike buttons are not visible)
  4. scroll back up to the like/dislike buttons

The dislike count is missing. After scrolling back up, the patch hook onComponentCreated is never called. Thus the dislikes are not added back in.

Solution

The patch likely needs adjustments

oSumAtrIX commented 1 year ago

This is due to the change of hook location due to the recent bump. A different location has to be hooked.

xDARKxDEVILx commented 1 year ago

Not only the dislike counter but the share and the other buttons has issue either appearing when they shouldn't or disappearing when they should appear , but i am too lazy to open an issue for this lol

LisoUseInAIKyrios commented 1 year ago

Fixed with https://github.com/revanced/revanced-patches/pull/1873