ReVanced / revanced-patches

🧩 Patches for ReVanced
https://revanced.app
GNU General Public License v3.0
2.37k stars 272 forks source link

feat(patch): com.instagram.android: Remove `igshid` from Share URL #1189

Closed stdedos closed 1 year ago

stdedos commented 1 year ago

Application

com.instagram.android

Issue

Remove igshid from Share URL

Patch

Remove igshid from Share URL

Motivation

igshid is probably some ig tracking. "Probably not necessary".

Acknowledgements

oSumAtrIX commented 1 year ago

What is igshid

oSumAtrIX commented 1 year ago

A query parameter? Not really necessary to remove

stdedos commented 1 year ago

Well - nothing is really necessary. I thought suggestions were welcome.

At least close it properly: Not planned 🙏

oSumAtrIX commented 1 year ago

Suggestions are welcome, but this issue is a request as the label on this issue suggests and a request can be denied. The motivation for denial is the lack of motivation provided in the issue. As the amount of requests rise, the threshold for acceptance rises too. I disagree with GitHub's choice of saying "Closed as unplanned" as it suggests the wrong message than this issue was closed with. GitHub should allow closing with custom reasons for example.

stdedos commented 1 year ago

GitHub should allow closing with custom reasons for example.

Yeah, I disagree with Github too 😕

However, they have this: image

and then ofc custom labels could fine-tune the reasoning.

But at least that gives an extra state to a boolean open/closed state.

oSumAtrIX commented 1 year ago

This side-info is not seen:

image

For that reason, it doesn't really add any benefit.

SodaWithoutSparkles commented 1 year ago

Github actually has guides on marking as duplicates: https://docs.github.com/en/issues/tracking-your-work-with-issues/marking-issues-or-pull-requests-as-a-duplicate

https://docs.github.com/en/get-started/writing-on-github/working-with-saved-replies/about-saved-replies

oSumAtrIX commented 1 year ago

Marking as duplicate has nothing to do with closing an issue.