feat(Twitch - Block embedded ads): Expand proxy support

ghost commented 1 year ago

Application

Twitch

Issue

If you try to watch twitch live streams with the actual supported proxies then it will buffer and you will see ads.

Patch

Add support to add custom (self hosted) proxys that support the ttv lol proxy protocol. For example to manually add luminous proxies https://as.luminous.dev or https://eu.luminous.dev from https://github.com/AlyoshaVasilieva/luminous-ttv-ext/releases/tag/v0.9.0. Those work the same like ttv lol and have a other/higher uptime+it proxies thorough Russia which is guaranteed adfree at the moment due to restrictions

Motivation

I would like proper ad blocking support in twitch on android. Right now the existing proxies have sometimes malfunctions and even if not everyone experiences them then it would still be useful if you could manually change the proxies for yourself for other motivations like privacy concerns.

Btw: adding support for the way how https://twitchls.com/ supports their way of adblocking is also fascinating

Acknowledgements

[X] I have searched the existing issues and this is a new and no duplicate or related to another open issue.
[X] I have written a short but informative title.
[X] I filled out all of the requested information in this issue properly.

oSumAtrIX commented 1 year ago

Those work the same like ttv lol

Is the implementation similar to this?

ghost commented 1 year ago

Sorry for the possible unhelpful response, but I am unable to properly answer this question as I dont know. I know the following things:

Ttv lol extension has a ttv lol proxy integration which is used too in revanced Twitch. Then ttv lol got forked resulting in ttv lol pro. In the issue stated in https://github.com/younesaassila/ttv-lol-pro/issues/30#issuecomment-1352581126 there is noted that the luminous dev proxies support the ttv lol api protocol. 1 day later it got added in ttv lol pro and it was possible to add custom sources such as luminous dev proxy.

In the foss backend of the luminous proxy got added support for the ttv lol api at v0.5 at release https://github.com/AlyoshaVasilieva/luminous-ttv/releases since december 3th.

If this is unhelpful then im sorry

Op zo 12 mrt. 2023 23:31 schreef oSumAtrIX @.***>:

Those work the same like ttv lol

Is the implementation similar to this https://github.com/revanced/revanced-integrations/blob/main/app/src/main/java/app/revanced/twitch/adblock/IAdblockService.java ?

— Reply to this email directly, view it on GitHub https://github.com/revanced/revanced-integrations/issues/329#issuecomment-1465317464, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANWWNKNMWAC5XS4267BPV6TW3ZFEFANCNFSM6AAAAAAVYL6CCE . You are receiving this because you authored the thread.Message ID: @.***>

kazimmt commented 1 year ago

Twitch v15.9.0 also compatible with Twitch patches but the issue with API

Here is some alternative working api https://github.com/2bc4/streamlink-ttvlol#known-compatible-public-proxy-servers

A text field would be good enough to add a new proxy.

ge022 commented 1 year ago

If proxy fails, maybe show the "purple screen". See twitchls.com how it blocks ads. The chrome extension "Stream Cleaner" has been reliably working for months now, it replaces ads with a 360p embed while ads play: blocktwitchads.com

ReVanced / revanced-patches