search

ReVanced / revanced-patches

🧩 Patches for ReVanced
https://revanced.app
GNU General Public License v3.0
2.04k stars 239 forks source link

bug: YouTube: SponsorBlock: Skipped Segments counter resets after app is closed #1431

Closed DrDragonKiller closed 1 year ago

DrDragonKiller commented 1 year ago

Type

Other

Bug description

When navigating to SponsorBlock settings it shows how many segments (and hours) you have skipped. When you close the app and reopen it the skipped segments counter is reset. It then shows 0 Skips and 0h for me in ReVanced (which is not correct) I verified that the setting Skip count tracking is still enabled.

In Vanced this setting worked as expected and was stored across app restarts.

Steps to reproduce

have sponsorblock patch installed watch a video with a skip segment (for example an LTT video) verify that the skip was registered under sponsorblock settings close the app (clear from open apps list ) reopen ReVanced open sponsorblock settings and see the counter being reset

Relevant log output

no log

Screenshots or videos

No response

Solution

permanently store the counter (just like in pther patches like remember playback rate)

Additional context

No response

SodaWithoutSparkles commented 1 year ago

Possible duplicate of ReVanced/revanced-patches-template#1468 Might be fixed by https://github.com/revanced/revanced-integrations/pull/298 c290a59