bug: error v2.147.0 (SEVERE: return-youtube-dislike failed)

Sappurit commented 1 year ago

Type

Error while patching

Bug description

SEVERE: return-youtube-dislike failed

Steps to reproduce

java -jar revanced-cli-2.18.2.jar -m revanced-integrations-0.87.0.apk -b revanced-patches-2.147.0.jar --keystore=revanced.keystore --options=options.toml -c -t %temp%/ReVanced-Cache -a Build/17.49.37/com.google.android.youtube_17.49.37.apk -o Build/17.49.37/app.revanced.andr oid.youtube_17.49.37.apk.1

Relevant log output

INFO: Reading dex files
INFO: Decoding AndroidManifest.xml only, because resources are not needed
INFO: Merging revanced-integrations-0.87.0.apk
INFO: Skipping predictive-back-gesture: Excluded by default
INFO: Skipping theme: Excluded by default
INFO: Deleting existing resource cache directory
SEVERE: Failed to delete existing resource cache directory
INFO: Decoding resources
INFO: always-autorepeat succeeded
INFO: client-spoof succeeded
INFO: comments succeeded
INFO: custom-branding succeeded
INFO: custom-video-buffer succeeded
INFO: custom-video-speed succeeded
INFO: debugging succeeded
INFO: disable-auto-captions succeeded
INFO: disable-auto-player-popup-panels succeeded
INFO: disable-fullscreen-panels succeeded
INFO: disable-startup-shorts-player succeeded
INFO: disable-zoom-haptics succeeded
INFO: downloads succeeded
INFO: enable-wide-searchbar succeeded
INFO: general-ads succeeded
INFO: hdr-auto-brightness succeeded
INFO: hide-album-cards succeeded
INFO: hide-artist-card succeeded
INFO: hide-autoplay-button succeeded
INFO: hide-captions-button succeeded
INFO: hide-cast-button succeeded
INFO: hide-create-button succeeded
INFO: hide-crowdfunding-box succeeded
INFO: hide-email-address succeeded
INFO: hide-endscreen-cards succeeded
INFO: hide-info-cards succeeded
INFO: hide-my-mix succeeded
INFO: hide-shorts-button succeeded
INFO: hide-time-and-seekbar succeeded
INFO: hide-video-buttons succeeded
INFO: hide-watch-in-vr succeeded
INFO: hide-watermark succeeded
INFO: microg-support succeeded
INFO: minimized-playback succeeded
INFO: old-quality-layout succeeded
INFO: open-links-directly succeeded
INFO: premium-heading succeeded
INFO: remember-video-quality succeeded
INFO: remove-player-button-background succeeded
SEVERE: return-youtube-dislike failed:
app.revanced.patcher.patch.PatchResultError
        at app.revanced.patcher.Patcher.executePatches$executePatch(Patcher.kt:429)
        at app.revanced.patcher.Patcher.access$executePatches$executePatch(Patcher.kt:44)
        at app.revanced.patcher.Patcher$executePatches$1.invokeSuspend(Patcher.kt:445)
        at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
        at kotlin.sequences.SequenceBuilderIterator.hasNext(SequenceBuilder.kt:127)
        at app.revanced.utils.patcher.PatcherKt.applyPatchesVerbose(Patcher.kt:83)
        at app.revanced.cli.patcher.Patcher.start$revanced_cli(Patcher.kt:20)
        at app.revanced.cli.command.MainCommand.run(MainCommand.kt:155)
        at picocli.CommandLine.executeUserObject(CommandLine.java:2026)
        at picocli.CommandLine.access$1500(CommandLine.java:148)
        at picocli.CommandLine$RunLast.executeUserObjectOfLastSubcommandWithSameParent(CommandLine.java:2461)
        at picocli.CommandLine$RunLast.handle(CommandLine.java:2453)
        at picocli.CommandLine$RunLast.handle(CommandLine.java:2415)
        at picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:2273)
        at picocli.CommandLine$RunLast.execute(CommandLine.java:2417)
        at picocli.CommandLine.execute(CommandLine.java:2170)
        at app.revanced.cli.main.MainKt.main(Main.kt:7)
Caused by: java.lang.NullPointerException
        at app.revanced.patches.youtube.layout.returnyoutubedislike.patch.ReturnYouTubeDislikePatch.execute(ReturnYouTubeDislikePatch.kt:55)
        at app.revanced.patches.youtube.layout.returnyoutubedislike.patch.ReturnYouTubeDislikePatch.execute(ReturnYouTubeDislikePatch.kt:24)
        at app.revanced.patcher.Patcher.executePatches$executePatch(Patcher.kt:425)
        ... 16 more
INFO: seekbar-tapping succeeded
INFO: settings succeeded
INFO: sponsorblock succeeded
INFO: swipe-controls succeeded
INFO: tablet-mini-player succeeded
INFO: video-ads succeeded
INFO: Compiling resources
INFO: Writing modified dex files
INFO: Aligning com.google.android.youtube_17.49.37.apk to app.revanced.android.youtube_17.49.37.apk_aligned.apk
INFO: Signing app.revanced.android.youtube_17.49.37.apk_aligned.apk to app.revanced.android.youtube_17.49.37.apk_signed.apk
INFO: Found existing keystore: revanced.keystore
INFO: Copying app.revanced.android.youtube_17.49.37.apk_signed.apk to app.revanced.android.youtube_17.49.37.apk.1
INFO: Cleaned up cache directory
INFO: Finished

Screenshots or videos

No response

Solution

No response

Additional context

I faced the issue with

revanced-cli-2.18.2.jar
revanced-integrations-0.87.0.apk
revanced-patches-2.147.0.jar
com.google.android.youtube_17.49.37.apk

Acknowledgements

[X] I have searched the existing issues and this is a new and no duplicate or related to another open issue.
[X] I have written a short but informative title.
[X] I filled out all of the requested information in this issue properly.

SCPF-Bot commented 1 year ago

ReVanced/revanced-patches-template#1572

LisoUseInAIKyrios commented 1 year ago

Compile each project (including revanced-cli), and use the jar files from that.

Or use Android ReVanced Manager to install.

johnconner122 commented 1 year ago

use this cli: https://github.com/inotia00/revanced-cli/releases/tag/v2.18.3

Sappurit commented 1 year ago

use this cli: https://github.com/inotia00/revanced-cli/releases/tag/v2.18.3

v2.18.3 from Mr.inotia00 work well. So it looks like revanced-cli bug. I thought that it couldn't use cross-developers. it will have a problem when reporting bugs.

ReVanced / revanced-patches