ReVanced / revanced-patches

🧩 Patches for ReVanced
https://revanced.app
GNU General Public License v3.0
2.04k stars 239 forks source link

bug: back button/gesture not working as intended #1526

Closed Cypher-Emm closed 1 year ago

Cypher-Emm commented 1 year ago

Type

Other

Bug description

The back button/gesture doesn't exit app. Using rooted yt patched with latest patches(not dev), integrations and cli. Back gesture works for exiting app only if i don't change any settings either youtube's settings or rv settings/sponsorblock. The predictive back gesture pack is excluded by default but i suspect this bug appeared after introduction of predictive back gesture patch. Device : Samsung Galaxy A10 (arm) Android 11 rooted stock one ui 3.1

Steps to reproduce

Patch yt with cli using latest patches, cli and integrations(not dev builds) After patching launch yt and test back key for exiting app. It will work . Now change some settings and the app won't exit with back gesture

Relevant log output

...

Screenshots or videos

No response

Solution

...

Additional context

Can anyone else reproduce this or is it only me

Acknowledgements

Domiiniik commented 1 year ago

Lmao 🤣🤣 this is false dude, the patches that are excluded take no effect on your app dude, besides this bug is really old and exists since quite some time before back gesture or android 13 even existed 🤣🤣

ghost commented 1 year ago

This should prevent the situation during which the back button does not work:

https://github.com/revanced/revanced-patches/pull/1369

oSumAtrIX commented 1 year ago

This should prevent the situation during which the back button does not work:

ReVanced/revanced-patches#1369

The back gesture remains non-functional. Instead, it adds a workaround whereas a faster and already existing workaround exists.

ghost commented 1 year ago

This should prevent the situation during which the back button does not work: ReVanced/revanced-patches#1369

The back gesture remains non-functional. Instead, it adds a workaround whereas a faster and already existing workaround exists.

Unfortunately there's no known way to restore the original back to exit feature. So this workaround should be good enough, because it's exactly the same of the stock one.

oSumAtrIX commented 1 year ago

The PR which was opened required swiping back twice.

ghost commented 1 year ago

The PR which was opened required swiping back twice.

The code of PR however can be adapted to all amount of swipes, also 1.

oSumAtrIX commented 1 year ago

In that case please adapt that.

ghost commented 1 year ago

In that case please adapt that.

@inotia00

Sunny-Shani commented 1 year ago

Same issue dude back button is not working :(

ghost commented 1 year ago

@oSumAtrIX This should be fixed now with last merged PR.

Cypher-Emm commented 1 year ago

Yup it is working properly now.

oSumAtrIX commented 1 year ago

@oSumAtrIX This should be fixed now with last merged PR.

Please link the PR.

ghost commented 1 year ago

@oSumAtrIX This should be fixed now with last merged PR.

Please link the PR.

https://github.com/revanced/revanced-patches/commit/24405877dd935a757fa61c7580887c1a47a25ea9

Sunny-Shani commented 1 year ago

@oSumAtrIX This should be fixed now with last merged PR.

Please link the PR.

2440587

Can you tell me what is PR? Do I have to install any new patches? Because mine back button still not working I am new here on github I don't know how things work.

oSumAtrIX commented 1 year ago

The PR has been abandoned by the author.

Sunny-Shani commented 1 year ago

The PR has been abandoned by the author.

It means that issue with back button still exists and I have to wait for it to be fixed?

indrastorms commented 1 year ago

the issue is fixed. why is it still opened?

Sunny-Shani commented 1 year ago

the issue is fixed. why is it still opened?

Not fixed dude mine still not working

indrastorms commented 1 year ago

Not fixed dude mine still not working

strange

Sunny-Shani commented 1 year ago

Not fixed dude mine still not working

strange

Your back button is working properly?

indrastorms commented 1 year ago

Your back button is working properly?

yes, absolutely. fixed by ReVanced/revanced-patches#1405