search

ReVanced / revanced-patches

🧩 Patches for ReVanced
https://revanced.app
GNU General Public License v3.0
2.15k stars 247 forks source link

feat(YouTube): Copy description and comments, video titles etc. #1538

Closed venkat2305 closed 4 months ago

venkat2305 commented 1 year ago

Application

YouTube

Issue

Makes it easier to copy the text in YouTube app

Patch

Ability to copy any text will be very helpful

Motivation

Makes it easier to copy the text in YouTube app

Acknowledgements

SodaWithoutSparkles commented 1 year ago

Transfered from #944

This is very useful, especially when the link in description fails to be detected, and you can copy it directly. Sometimes you can copy the lyrics of a song. You can also copy the title/name of a show/PV and search it, instead of typing it out, which sometimes is not possible as you dont have that keyboard installed and dont know the language (anime PV, for example)

Epyxoid commented 1 year ago

Is this planned? Because I was about to create another issue with this but luckily I noticed there are already issues addressing this, but almost all of them are "closed as not planned". What does that mean? Is it too difficult to implement? Or simply you just closed all the other duplicates?

Edit: Cool! Good to know!

kairusds commented 7 months ago

Is it also possible to make them have a translate button too like in comments?

oSumAtrIX commented 7 months ago

@kairusds https://github.com/ReVanced/revanced-patches/issues/1153

issssse commented 6 months ago

Yes, please implement this! It is a huge flaw in youtube and would make life so much easier. Right now, you would either have to screenshot and use text recognition, or copy link into browser, open desktop mode and find the relevant comment/description/title. Simply put, it's a big pain in the ass.

kairusds commented 6 months ago

As of v19.04.37, you can copy texts on the description now so there's no need for this patch anymore.

SodaWithoutSparkles commented 6 months ago

As of v19.04.37, you can copy texts on the description now so there's no need for this patch anymore.

This patch isnt limited to descriptions. This patch is also extended to comments and titles.

As of v19.04.37, you cannot copy texts on the titles and comments so there's still a need for this patch

oSumAtrIX commented 4 months ago

Closing the issue as it turns out that copying text from a screen is possible via third party apps with ease.

SodaWithoutSparkles commented 4 months ago

Closing the issue as it turns out that copying text from a screen is possible via third party apps with ease.

Please name such apps.

Also does that differ from using OCR? If so, OCRs may not be accurate, especially when dealing with CJK languages.

oSumAtrIX commented 4 months ago

You will find plenty on Google searching for text selection apps, not OCR, pick one

SodaWithoutSparkles commented 4 months ago

You will find plenty on Google searching for text selection apps, not OCR, pick one

Please name one of these apps such that I could test. None of the 7 ones I found by seaeching "text selection apps" support copying in-app.

Using accessibility settings is not acceptable as this could cause privacy concerns and will cause other secure apps (e.g. banks) stopps working.

oSumAtrIX commented 4 months ago

This is an issue tracker and not a place to discuss available apps. Here is one using accessibility services which given your position in this circumstance will be more than acceptable: https://play.google.com/store/apps/details?id=com.camel.corp.universalcopy

If you have Luxus problems, feel free to open a PR