ReVanced / revanced-patches

🧩 Patches for ReVanced
https://revanced.app
GNU General Public License v3.0
2.04k stars 239 forks source link

bug: SponsorBlock's `Skip segment` button's position is displayed in an unintended place in fullscreen #1546

Closed inotia00 closed 1 year ago

inotia00 commented 1 year ago

Type

Error at runtime

Bug description

SponsorBlock's Skip segment button is displayed in an unintended place in fullscreen

Steps to reproduce

  1. Include the sponsorblock patch
  2. Change the Hide fullscreen panels switch to off
  3. Play a video with SponsorBlock segments, enter fullscreen when the 'Skip segment' button is displayed

Relevant log output

N/A

Screenshots or videos

before : Unintended Position (currently ReVanced)

after : Position intended by Vanced developers

Solution

I'll leave a PR

Additional context

In the process of migrating Vanced's code to ReVanced, some code responsible for the location of SponsorBlock's Skip segment button was missing

It's an old enough and minor issue, but it hasn't been reported so far, so I've created an issues page

Acknowledgements

indrastorms commented 1 year ago

Also the create new segment's 'buttons layout'.

LisoUseInAIKyrios commented 1 year ago

Fixed with https://github.com/revanced/revanced-patches/pull/1557