ReVanced / revanced-patches

🧩 Patches for ReVanced
https://revanced.app
GNU General Public License v3.0
2.47k stars 286 forks source link

bug: YouTube error 'settings' failed to resolved ThemeSetterAppFingerprint #1564

Closed hyoretsu closed 1 year ago

hyoretsu commented 1 year ago

Type

Error while patching

Bug description

revanced/revanced-manager#614

Steps to reproduce

Try to patch latest YouTube version.

Relevant log output

Initializing installer
Creating working directory
Copying original apk
Unpacking input apk
Reading dex files
Decoding AndroidManifest.xml only, because resources are not needed
Merging integrations
Deleting existing resource cache directory
Decoding resources
Applied client-spoof
Applied custom-branding
Failed to apply custom-video-buffer: 'custom-video-buffer' depends on 'settings' but the following error was raised: Failed to resolve ThemeSetterAppFingerprint
Applied custom-video-speed
Failed to apply debugging: 'debugging' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Failed to apply disable-startup-shorts-player: 'disable-startup-shorts-player' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Failed to apply downloads: 'downloads' depends on 'downloads-resource-patch' but the following error was raised: 'downloads-resource-patch' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Failed to apply general-ads: 'general-ads' depends on 'GeneralAdsResourcePatch' but the following error was raised: 'GeneralAdsResourcePatch' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Failed to apply hdr-auto-brightness: 'hdr-auto-brightness' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Applied hide-my-mix
Failed to apply hide-watermark: 'hide-watermark' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Failed to apply open-links-directly: 'open-links-directly' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Applied predictive-back-gesture
Failed to apply premium-heading: The file /data/user/0/app.revanced.manager.flutter/cache/patcher/tmp-SMNXKW/cache/res/drawable-xxxhdpi/yt_premium_wordmark_header_light.png does not exist in the resources. Therefore, this patch can not succeed.
Failed to apply remember-video-quality: 'remember-video-quality' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Failed to apply return-youtube-dislike: 'return-youtube-dislike' depends on 'return-youtube-dislike-resource-patch' but the following error was raised: 'return-youtube-dislike-resource-patch' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Failed to apply settings: 'settings' did not succeed previously
Failed to apply sponsorblock: 'sponsorblock' depends on 'sponsorblock-resource-patch' but the following error was raised: 'sponsorblock-resource-patch' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Failed to apply video-ads: 'video-ads' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Repacking patched apk
Compiling resources
Writing modified dex files
Finished!

Screenshots or videos

No response

Solution

No response

Additional context

No response

Acknowledgements

oSumAtrIX commented 1 year ago

Looks like you are using outdated patches because this has been resolved in the latest ones here:

https://github.com/revanced/revanced-patches/commit/83ebc731130d3d216ac4b815382d8f13548cf665#diff-0924fca91ad29b2980b630366b104f0740c93b22dc007a9bba1ba9b79a55ce68R9

hyoretsu commented 1 year ago

How do I fix that then? I'm using the latest version of ReVanced Manager (v0.0.52) and they said it wasn't related to it.

oSumAtrIX commented 1 year ago

The issue is that the ReVanced Manager failed to update the patches. Your best bet would be to fiddle around by refreshing or even reinstalling the application to get it updated, or you can use the CLI or manually downlosd the latest bundle and use it in the app.

hyoretsu commented 1 year ago

I first installed it some 3 hours ago. I used "reset patches" and made sure the tag from "Select patches" was saying v2.146.0 (latest version). I saw the fix commit mentioned in the patch notes for this version, but the error still persists.

I'll try from CLI to see if I also get it.

mkujer commented 1 year ago

I first installed it some 3 hours ago. I used "reset patches" and made sure the tag from "Select patches" was saying v2.146.0 (latest version). I saw the fix commit mentioned in the patch notes for this version, but the error still persists.

I'll try from CLI to see if I also get it.

Hi, Hope you got it working yet. The solution for me was to clear Cache/Dalvik inside of TWRP Manager. The application seem to have been outdated even if re-installed many times.

AndreiMiculita commented 1 year ago

I installed the revanced-manager app in the past hour, for the first time ever. I'm still having this issue. I tried clearing the cache, but it didn't work, unfortunately.

B10Reaper commented 1 year ago

So what's the solution? I see the patch page but I'm not sure how one imports from the page. Is it an option in the app?

oSumAtrIX commented 1 year ago

@B10Reaper ReVanced/revanced-patches#1332 is still open/your issue is a dupe.

B10Reaper commented 1 year ago

@B10Reaper ReVanced/revanced-patches#1332 is still open/your issue is a dupe.

It says closed, is that not what that means?

For some reason, patching the APK from apkmirror.com rarher than the app after installation goes just fine, no issues. I have no idea why, but there we go, if anyone else has issues.

Ushie commented 1 year ago

It says closed

Yes, this issue is closed, because it is a duplicate

the original issue is ReVanced/revanced-patches#1332, you can move there