BTTV Android - Githubissues

ReVanced / revanced-patches

🧩 Patches for ReVanced

https://revanced.app

GNU General Public License v3.0

2.36k stars 270 forks source link

BTTV Android #1607

Closed albertopasqualetto closed 1 year ago

albertopasqualetto commented 1 year ago

Application

BTTV Android

Issue

Same patches as Twitch

Patch

Same patches as Twitch

Motivation

It is the same as original Twitch, but with some enhancements, so it should support the same patches.

Acknowledgements

[X] I have searched the existing issues and this is a new and no duplicate or related to another open issue.
[X] I have written a short but informative title.
[X] I filled out all of the requested information in this issue properly.

ggtylerr commented 1 year ago

TBH it'd be better to have a BTTV / FZ / whatever patch for the twitch app, rather than the other way around. I do think the BTTV app should be supported in some way though, like how the original vanced app is supported.

albertopasqualetto commented 1 year ago

TBH it'd be better to have a BTTV / FZ / whatever patch for the twitch app, rather than the other way around. I do think the BTTV app should be supported in some way though, like how the original vanced app is supported.

@ggtylerr you are right, but in the logic of not reinventing the wheel I thought that the other way would have been a lot easier.

einekratzekatze commented 1 year ago

What needs to happen that someone works on this?

albertopasqualetto commented 1 year ago

I think that this app's patch is no longer needed since there is Purple TV now. Consider closing this issue.

einekratzekatze commented 1 year ago

I think that this app's patch is no longer needed since there is Purple TV now. Consider closing this issue.

PurpleTV?

albertopasqualetto commented 1 year ago

PurpleTV?

Yes, their Discord.

einekratzekatze commented 1 year ago

PurpleTV?

Yes, their Discord.

Is it not open source? Only an open source project might make this Issue insignificant (and even then revanced power is to be flexible. You can install the patches you want and not just get hit with the full package)

albertopasqualetto commented 1 year ago

@einekratzekatze Ehm, it was open source, now their gitlab is open only to their subscribers.

ggtylerr commented 1 year ago

@einekratzekatze Ehm, it was open source, now their gitlab is open only to their subscribers.

That's not open source... but yeah, while it has merit as a FOSS alternative (and one which utilizes patches instead of full mods), it's definitely a lower priority. I wouldn't suggest closing for this reason though, moreso because ReVanced/revanced-patches-template#1561 exists.

oSumAtrIX commented 1 year ago

Wrong repository: https://github.com/bttv-android/bttv

einekratzekatze commented 1 year ago

Wrong repository: https://github.com/bttv-android/bttv

What do you mean?

oSumAtrIX commented 1 year ago

You are requesting a feature for BTTV: https://github.com/bttv-android/bttv

einekratzekatze commented 1 year ago

You are requesting a feature for BTTV: https://github.com/bttv-android/bttv

No, this Issue is about providing an adblocker patch for BTTV, as BTTV doesnt want it for some stupid reason and we already have adblockers for normal twitch.

ggtylerr commented 1 year ago

You are requesting a feature for BTTV: https://github.com/bttv-android/bttv

The app I was referring to was PurpleTV, which was the app being talked about and referenced in the replies before mine.
As @einekratzekatze said, BTTV has chosen not to add an adblocker.

Again, please reopen this if that's your reaaoning for closing...

oSumAtrIX commented 1 year ago

The issue title is Bttv, and if BTTV has chosen not to add an adblocker, you can fork it.