ReVanced / revanced-patches

๐Ÿงฉ Patches for ReVanced
https://revanced.app
GNU General Public License v3.0
2.23k stars 260 forks source link

feat(YouTube): Playback Speed button, drag slider, double-tap zones #1620

Closed Coldblackice closed 3 months ago

Coldblackice commented 1 year ago

Application

YouTube (com.google.android.youtube)

Issue

Currently, Playback-Speed control requires jumping into sub menus, necessitating multiple screen taps each time a speed change up or down or default is desired.

On desktops, keyboard shortcuts "<โ€ and ">" change playback speed on the fly, but obviously this isn't practical on mobile devices.

Patch

To more quickly and directly change a video's playback speed, it would be fantastic if any of the following could be implemented:

A fine-grained speed scale wouldn't be necessary, even merely sliding between default .5x--1x--1.5x--2x would be phenomenal.

Motivation

Reason:

This patch would provide quick, direct access for a user to change playback-speed on the fly -- because some parts of a video might not be ideal at 2x, like technical explanations, while other parts could use a speed bump.

This optional patch for changing playback-speed via an on-video button, or drag-slider, or double-tap would cut out the need for multiple screen taps + sub menus each time a user wants to change speeds.

Acknowledgements

aronnoordhoek commented 1 year ago

I just posted a similar idea on Reddit before seeing you had opened this. I had the idea to pair the speed adjustment dragging with scrubbing in a horizontal split just like the brightness-volume split.

The scrubbing could also be based on a setting so that people could choose to scrub normally or precisely/per frame.

Post: https://www.reddit.com/r/revancedapp/comments/zjb62l/idea_for_a_patch_the_blue_and_yellow_horizontal/ Image of idea: https://i.imgur.com/T3C7EPF.png

nochlab1 commented 1 year ago

closing the other issue means that this idea is actually being done?

oSumAtrIX commented 1 year ago

It means they both were duplicates of each other.

nochlab1 commented 1 year ago

oh i got excited

Bluscream commented 1 year ago

same here

nightgolfer commented 1 year ago

Is this still not a thing? Seems like such an easy QOL improvement, really wish there was an simple way to change playback speed without having to go into menus. I have volume buttons on my phone, let me scrub playback speed instead, please. Or a dedicated button, that would also be fine. Anything to avoid having to go through multiple menus ๐Ÿ˜ณ

Tap video for controls. Tap settings icon. Tap playback speed setting. Tap desired speed. ๐Ÿ˜ฎโ€๐Ÿ’จ

megamorphg commented 7 months ago

I switch between 1x and 2x speed pretty frequently (some videos just have to be watched on either speed). One way to implement this is to have custom-defined buttons on the overlay like the browser script has.

mizoru commented 6 months ago

Really want for this to be created

megamorphg commented 3 months ago

@oSumAtrIX The 1st part of this request is complete, but there are two other bullets which could simply be addressed: would it be possible to make it so that holding the speed button toggles to the last used speed? (Kind of like the "hold the copy URL button to copy with the timestamp.")

It already is a big improvement but this would be a huge improvement further not to have a dialog to have to click through... since it is common to switch back and forth from 1x to a faster speed pretty often for a lot of people,

Bluscream commented 3 months ago

This is no longer needed since grayjay exists now