ReVanced / revanced-patches

🧩 Patches for ReVanced
https://revanced.app
GNU General Public License v3.0
2.43k stars 281 forks source link

bug: In certain devices, gesture volume goes up to 150, instead of 15. #1646

Closed d3EyedRaven closed 1 year ago

d3EyedRaven commented 1 year ago

Type

Other

Bug description

On certain devices (I have Redmi Note 10 Pro), the volume with gestures enabled goes up to level 150 instead of 15. The drag speed is also same as level 15, so in one drag maximum volume I can change is 30. That's 5 full drags to change from min to max volume and max to min.

Steps to reproduce

  1. Enable gesture for brightness and volume

  2. Use volume gesture to increase or decrease volume

  3. Instead going through level 0 through 15, it goes 0 through 15 with same slow drag speed.

Relevant log output

sorry not available

Screenshots or videos

No response

Solution

Currently it's 100 levels for brightness with high drag sensitivity, and 15 levels for volume with low drag sensitivity.

I think it's fair to do 30 levels of brightness and volume in all devices, as in MX Player, (or 100 as in VLC Android) for the same drag sensitivity.

Additional context

No response

Acknowledgements

SodaWithoutSparkles commented 1 year ago

Unable to replicate the volume goes up to 150 issue. Currently on:

Can you submit a screen record as proof? Theres a built-in screen recorder on MIUI devices, but remember to keep it at ≤30fps and short, as GitHub only allows videos up to 10MB

oSumAtrIX commented 1 year ago

This depends on your phone

d3EyedRaven commented 1 year ago

@SodaWithoutSparkles

done Redmi Note 10 Pro all configuration same as yours. (youtube lagged when capturing uploaded video)

thread of other user with same issue: https://www.reddit.com/r/revancedapp/comments/z0vzul/it_takes_around_7_to_8_swipes_to_increase_volume/

https://user-images.githubusercontent.com/71594081/205683314-e953d214-fcc2-4652-9fc3-076724b52619.mp4

SodaWithoutSparkles commented 1 year ago

okay... looks strange indeed. Can you enable the show touch option in screen recorder?

BTW, whats that video? I want to have a sample to see if it is spectific to portrait video being played in landscape

oSumAtrIX commented 1 year ago

Its not strange as previously implied, because his phone only has this many steps for volume.

d3EyedRaven commented 1 year ago

Hi @SodaWithoutSparkles Link to first video: https://youtu.be/rz1Ad5Yizbk

New video that's fully landscape: https://youtu.be/iZnLZFRylbs

https://user-images.githubusercontent.com/71594081/205692614-5b95501a-da88-491c-975e-180b554dde7e.mp4

As @oSumAtrIX mentioned, my phone has indeed that many steps for volume i.e. 150, however i couldn't find solution to that.

Is this possible?

I think it's fair to do same levels of brightness and volume in all devices, 30 as in MX Player, or 100 as in VLC Android for the same swiping sensitivity.

SodaWithoutSparkles commented 1 year ago

ok. does using the OG youtube, (with the same version,) has this problem as well?

I dont think theres any way for a android phone to have volume over 15. Thats certainly abnormal. Maybe it will be converted from 0-150 to 0-15 scale?

Can OP also monitor the volume by the system volume meter? Press volume once, then swipe the volume, observe if the bar changes as well. But be quick, the bar would disappear in less than 3 seconds

d3EyedRaven commented 1 year ago

pressing volume button changes the volume using 0-15 scale. swiping changes the volume using 0-150 scale.

at one point i had just kept the volume swiping off just because of low swiping sensitivity.

@SodaWithoutSparkles

this problem only occurs in revanced youtube. None other application, including stock youtube, latest version.

update: I just tried vanced youtube using vanced manager, it had same issue, but at least swiping sensitivity is fast, same as brightness swipe. had to swipe once or twice to get to max volume instead of six swipes at revanced. i also tried turning miui optimizations off like vanced manager asked me to, it didn't help.

maghuro commented 1 year ago

Didn't happened on my Xiaomi 10T pro, and now it's happening in my 12T pro - 150 steps to boost volume, even if pressing the volume buttons!

Is there something I have to change? I can't find anything.

SodaWithoutSparkles commented 1 year ago

@oSumAtrIX it does depends on the phone, but the user just sees the 0-15 UI. They dont see the 0-150 UI in anywhere except revanced/old-vanced. Maybe a workaround can be installed, like IF the range is 0-150, then jump for 10 units at once instead of 1

LemonadeG commented 1 year ago

Same problem on Poco F3 using MIUI 13

LaundryHamper commented 1 year ago

I also have this issue. My phone is a Xiaomi Redmi Note 10 Pro (...2 Alpha HD Remaster & Knuckles: The Lost Levels), so it isn't a device-specific issue, it's specific to MiUI, and it's an issue which can be accounted for and avoided by the application. Whatever way volume control was implemented in Vanced resulted in the normal 0-15 scale on this same phone. ReVanced has the 0-150 scale, but only when the video is playing in fullscreen.

Reddit is Fun also has this issue, but again only when a video is fullscreen.

Vimeo does not have this issue, even when fullscreen.

It probably has something to do with Xiaomi wanting MiUI's floating volume sliders to appear infinitely scalable like those on the iPhone.

On top of how annoying to use this makes the swipe gesture, it takes slightly more than eight seconds to go from one end of the scale to the other holding down the volume button, which isn't great if you need your phone to shut up in a hurry.

SodaWithoutSparkles commented 1 year ago

@LaundryHamper Can you try executing termux-volume in termux? You probably need termux:api as well.

https://f-droid.org/packages/com.termux https://f-droid.org/packages/com.termux.api

if the packages are missing, install them as prompted.

Example output:

[
  {
    "stream": "call",
    "volume": 11,
    "max_volume": 11
  },
  {
    "stream": "system",
    "volume": 8,
    "max_volume": 15
  },
  {
    "stream": "ring",
    "volume": 8,
    "max_volume": 15
  },
  {
    "stream": "music",
    "volume": 9,
    "max_volume": 15
  },
  {
    "stream": "alarm",
    "volume": 10,
    "max_volume": 15
  },
  {
    "stream": "notification",
    "volume": 8,
    "max_volume": 15
  }
]

What i am interested in is the max_volume number. Does the OS reports the correct one or a wrong one?

dev0nizer commented 1 year ago

Looks like a Xiaomi related bug, my device is Xiaomi Pad 6 and I'm facing the same issue Also, the status of the issue is "closed", but there is no solution :(

SodaWithoutSparkles commented 1 year ago

@dev0nizer try the termux thing i mentioned above. Wanna get some more insights

dev0nizer commented 1 year ago

@SodaWithoutSparkles apologies for the late response

[
  {
    "stream": "call",
    "volume": 8,
    "max_volume": 11
  },
  {
    "stream": "system",
    "volume": 10,
    "max_volume": 15
  },
  {
    "stream": "ring",
    "volume": 10,
    "max_volume": 15
  },
  {
    "stream": "music",
    "volume": 75,
    "max_volume": 150
  },
  {
    "stream": "alarm",
    "volume": 12,
    "max_volume": 15
  },
  {
    "stream": "notification",
    "volume": 10,
    "max_volume": 15
  }
SodaWithoutSparkles commented 1 year ago

So it does report the 150 number. @oSumAtrIX maybe add a sensitivity option for swipe controls?

dev0nizer commented 1 year ago

@SodaWithoutSparkles changing volume with buttons is also extremely slow (I need to hold the "volume down" button for 3-4 seconds to change the volume from 150 to 0), so it would be great to have a scale control for both buttons and swipe gestures, or implement some other fix

clicky6 commented 11 months ago

Any module or hack which can make the the volume steps that are currently 15 on my device in Revanced to 100 or 150?

Youngei402tw commented 3 months ago

I am still having this issue, I had a poco f6 pro

Youngei402tw commented 2 months ago

This issue should not be closed, the issue still excist, and the pushed commit has a wrong reference to this issue, the pushed commit is about twitter not youtube...