Closed YouSummoner closed 1 year ago
Exclude patches and check if the error dissappears.
What patches do yo think will need to be excluded?
Not sure, try with no patches first.
Tried excluding some, it stills crashes. Here's the current patches selection...
The project is in dire need of some quality control...
I asked to try with no patches first.
I tried without patches, it works fine. Also I tried the non root version, it's crashing too...
Non root requires the patch for MicroG. This issue is specific for root and not non root. Now comtinue to add patches until the error appears as originally suggested. Respond back with the patch causing the issue.
I said it's crashing on non root too with the MicroG patch included, the same way it did on root version.
Related/Dupe of ReVanced/revanced-patches#1091.
If possible attach a full detailed recording of the following:
I'm giving updates properly, no need for recording, also don't have much data, sorry.
A recording is required, otherwise this issue can not be reopened.
A recording is required, otherwise this issue can not be reopened.
Here, I found the culprit, it's the video-ads patch, do something please...😭 Even just disabling the video-ads toggle from revanced settings fixes it, but then what's the point of using revanced...
Here's the recording, couldn't directly upload because of GitHub files size limit. https://gofile.io/d/U8rXsq
Did you try other patches as well?
Yes, but excluding video ads patch fixes the issue, other patches work fine.
try out older versions of the patches, report back which one introduces the error.
Whaa, dunno how to, I'm on corvus OS 4.0 BTW, also heard that someone is having this issue on derpfest as well, if that helps...
I tried installing builds made using older version of patches, it's happening in those too, maybe it's a YouTube source side change, the video ads patch needs a urgent update please 🥺...
Unlikely, which version was the last which worked?
17.43.36 world before, but isn't working now
Please report back the exact version of the app and the patches which worked.
OMG, checked just now, I installed the official YouTube app without any patches, it plays ads and then crashes without playing the video, what fixes this behaviour is signing out of the account...
All patches except video-ads and sponsorblock are being applied successfully in YouTube v17.46.37 and the app isn't even crashing in this version, now all that's needed is to update those two patches for this new YouTube version and everything will work as intended...
Once again, please respond back with the exact version of the app and the patches which worked before. v17.46.37 was never supported.
v17.43.36 worked before, but now isn't, every version below v17.46.37 is having this issue right now when I checked. That's why I request to support v17.46.37 ASAP and get rid of all this headache... As I said only two patches video ads and sponsorblock are failing in this latest version.
You forgot to tell the version of the patches which v17.43.36 worked with.
I really don't remember that, but It was about a month ago, soooo
In that case do as suggested: https://github.com/revanced/revanced-patches/issues/1169#issuecomment-1333379398
Nah, YouTube base itself is causing the crashes, even without any patches on all older versions, I'd better just wait for revanced to support the newer version.
In any case, without the required information there will not be a fix for your issue.
The only fix is updating the patches for the latest YouTube version, cz it's not crashing or having any issues, forget about the previous versions of YouTube and their errors now.
This is not how it works, until we know which version worked last we wont know what change caused the error.
Type
Error at runtime
Bug description
Some videos Play fine, but some crash YouTube in rooted version.
Steps to reproduce
Relevant log output
Screenshots or videos
.
Solution
.
Additional context
.
Acknowledgements