ReVanced / revanced-patches

🧩 Patches for ReVanced
https://revanced.app
GNU General Public License v3.0
2.49k stars 290 forks source link

feat: Restore the built-in Call Recording feature on the Google Phone app #168

Closed mina-gaid closed 5 months ago

mina-gaid commented 1 year ago

Feature description

Develop and release a patch that restores the built-in call recording feature on the official Google Phone app, where this feature is locked/hidden by Google due to regional regulations. This patch should allow users to access and use the phone recording feature regardless of their region using the Google Phone app.

The functionality already exists on the Google Phone app but is now locked/hidden in certain regions or devices, as per the official documentation: https://support.google.com/phoneapp/answer/9803950?hl=en

Certain markets, such as India, still have access to the Call Recording feature.

The Pixel line up offered Call Recording via the Google Phone app until it was removed (hidden/locked) following an update.

Attached - Screenshot of call recording on the Google Phone app before it was removed:

google-phone-call-recording-xda-1

Motivation

Many users require access to their device’s built-in call recording feature for legitimate purposes. However, due to regional regulations, some OEMs lock this feature, limiting the user’s ability to fully utilize their device. By enabling this feature, we can improve the user experience by adding comprehensive control over our devices.

On some devices, such as OnePlus, the call recoding feature can be unlocked via an ADB Command (Non-Root). However, this doesn't work on all phones, such as the Pixel range because every OEM has their own modified version of the stock Android phone app. By specifically patching the official Google phone app, all Android users can be catered for regardless of device because the app is available to download on the Play store - and more often than not, it's most people's default choice.

Acknowledgements

KobeW50 commented 1 year ago

If mounting the patched app will be required for this, I suggest creating a similar patch for other popular calling apps which wouldn't need mounting (in order to help out the non-root users).

mina-gaid commented 1 year ago

It wouldn't be practical due to maintenance concerns. I previously made a similar request that applied to all the default stock phone apps by major OEMs. However, it was pointed out that these apps aren't as similar as one might think. Admittedly, I don't have much knowledge about Android apps.

The reason it wouldn't work is that not all devices have the necessary built-in capabilities. To the best of my knowledge, only OnePlus, Samsung, and certain Pixel phones offer this feature, and it's either region-locked or completely removed after an update.

The most viable solution is to patch the Google phone app, which is the default for Pixel phones and is also available on the Play Store for other devices. This feature was also once available in the Google phone app for Pixel phones before it was removed.

I want to emphasize that I'm aware of third-party apps that offer this capability, but they are impractical, riddled with intrusive ads, and often require a monthly subscription. Restoring this feature to the Google phone app would be a fantastic solution and would cater to all Android phones regardless of make or model.

dib12 commented 1 year ago

@mina-gaid call recording can be enable easily if u have this XML file. If rooted copy to product/etc/permission. And check.

https://dumps.tadiphone.dev/dumps/redmi/sky/-/blob/missi_phone_global-user-13-TKQ1.221114.001-V14.0.5.0.TMWINXM-release-keys/product/etc/permissions/com.google.android.apps.dialer.call_recording_audio.xml

Demerit of Googledialer is call announce. Which need patch

Revanced patch idea also good. Let's wait for dev to add this feature

mina-gaid commented 1 year ago

@dib12 Yeah, Googledialer call recording announcement is annoying, but as you said, that can be a separate patch.

I personally don't mind the announcement, as I only need it when making calls with Amazon support, bank etc who are also recording me. Most support agents use to think it was hilarious that I was recording them back. 😂

That XML is great, but a patch would be more convenient. Hopefully the devs pick it up.

Pheggas commented 10 months ago

@mina-gaid call recording can be enable easily if u have this XML file. If rooted copy to product/etc/permission. And check.

https://dumps.tadiphone.dev/dumps/redmi/sky/-/blob/missi_phone_global-user-13-TKQ1.221114.001-V14.0.5.0.TMWINXM-release-keys/product/etc/permissions/com.google.android.apps.dialer.call_recording_audio.xml

Demerit of Googledialer is call announce. Which need patch

Revanced patch idea also good. Let's wait for dev to add this feature

Is there a way for non-rooted devices?

mina-gaid commented 10 months ago

@Pheggas Nope, and the XML option is both tedious and temporary. That's why I'm requesting a patch for this.

validcube commented 10 months ago

Is this really possible, isn't the permission required for call recording locked behind a system permission called CAPTURE_AUDIO_OUTPUT?

oSumAtrIX commented 5 months ago

Over time, a lot of feature requests have been made, which is why I am closing some according to the contribution guidelines:

Requests can be accepted or rejected at the discretion of maintainers of ReVanced Patches

This feature request has been closed for one or more of the following reasons:

Regardless, anyone who comes across this feature request can PR it. Thanks for the feature request!