ReVanced / revanced-patches

🧩 Patches for ReVanced
https://revanced.app
GNU General Public License v3.0
2.2k stars 257 forks source link

bug: Progress bar leaves a lining in full screen #1770

Closed amit-katyal closed 1 year ago

amit-katyal commented 1 year ago

Type

Cosmetic

Bug description

The progress bar of video in full screen leaves a black lining at the position of progress bar.

Steps to reproduce

Step 1. Play any video Step 2. Double tap to go forward or backward. Sometimes merely tapping to reveal player buttons also causes the issue. Step 3. Move the progress bar around Step 4. Observe the lining at the position of progress bar

Relevant log output

Debugging patch excluded

Screenshots or videos

https://user-images.githubusercontent.com/89385446/201340693-ecdf6213-dc84-46b1-8c4d-5e47ae616a3e.mp4

Solution

Clearing app data or reinstallation of app.

Additional context

I reinstalled the app yesterday and the bug went away. But today it came back again. I'm not sure what causes it in specific. I've tried to turn off sponsorblock (from settings, not excluding the patch), still the bug is there.

Acknowledgements

oSumAtrIX commented 1 year ago

Do not force dark mode on the app in your phone settings.

amit-katyal commented 1 year ago

It's already off. Still the same issue.

https://user-images.githubusercontent.com/89385446/201353505-963702df-d722-4cb6-a602-8693e98e4db3.mp4

oSumAtrIX commented 1 year ago

Find the patch which causes the issuel and report back with it by disabling patches until the error is gone.

amit-katyal commented 1 year ago

I don't think this is an issue with a patch. Just a cosmetic bug from YouTube (I don't have vanilla installed so I can't confirm) or maybe revanced team due to some modification. Here is something I observed:

  1. Not Forcing revanced to be on dark mode in system settings (in dark mode) leaves a black lining

  2. Forcing revanced to be on dark mode in system settings (in dark mode) leaves a white lining

  3. Turing off dark mode (using light mode) doesn't leave any lining behind

https://user-images.githubusercontent.com/89385446/201383187-0af7ab44-5f7c-4618-96d3-252680664dbe.mp4

By the way, I'm using OnePlus Nord, Oxygen OS 11 based on Android 11. I never had this lining issue whatsoever with vanced or with previous versions before ambient mode and new interface came.

https://user-images.githubusercontent.com/89385446/201383539-552c372f-c87f-416d-bcbe-e0bc3a2bb68c.mp4

Observe the color of progress bar in dark mode, changing from white and red. But in light mode it stays only red. Maybe something related to this?

oSumAtrIX commented 1 year ago

Please try this as suggested.

amit-katyal commented 1 year ago

Here it is.

https://user-images.githubusercontent.com/89385446/201390688-1a8b963b-7f72-463b-b9c3-82f429279b24.mp4

Plut0nio commented 1 year ago

I have this issue as well, even after disabling/hiding fullscreen panels. (YT version 17.45.36, patches version 2.141.0)

FrosT2k5 commented 1 year ago

Why was this issue closed without providing proper solution? I am facing it too

amit-katyal commented 1 year ago

I'm not facing the issue anymore actually. So I closed it. I'm using v17.45.36 with patches v2.140.0 currently

I'll reopen it. If you're still facing the issue.

oSumAtrIX commented 1 year ago

@FrosT2k5 Please try this as suggested.

Plut0nio commented 1 year ago

@FrosT2k5 Please try this as suggested.

I also tried that when I attempted to fix this, but I still have the issue, even with fullscreen panels disabled. Should I use an older patch version?

According to xkritical#8195 on the Discord, this is apparently an issue with the stock YT app and not with ReVanced, so idk if that would even actually fix it.

Kalpataru6 commented 1 year ago

I'm also facing this same problem.. And I can confirm the stock youtube all also have the same bug.. When I requested for a patch to hide it osu told me it is a bug of youtube and I should request youtube team

Sculas commented 1 year ago

Was this issue fixed or not? I'm still having this issue as well and I don't even have the option to force dark mode on YT in my phone settings.

oSumAtrIX commented 1 year ago

Was this issue fixed or not? I'm still having this issue as well and I don't even have the option to force dark mode on YT in my phone settings.

I suggest trying this.

Sculas commented 1 year ago

Then don't close the issue as completed if the problem still exists?

oSumAtrIX commented 1 year ago

Then don't close the issue as completed if the problem still exists?

What i suggested is not an implication of that it is not completed. Please make sure you read the issue fully.

FrosT2k5 commented 1 year ago

If someone still has this issue. I patched newer version of youtube with newer patches and it was fixed, I recommend to do the same.

Kalpataru6 commented 1 year ago

I'm still on the older version but the issue just disappeared automatically.. People really did not like this so youtube removed it.