ReVanced / revanced-patches

🧩 Patches for ReVanced
https://revanced.app
GNU General Public License v3.0
2.04k stars 239 forks source link

bug: SponsorBlock Skips Random Sections of Shorts #1792

Closed george-emerald closed 1 year ago

george-emerald commented 1 year ago

Type

Error at runtime

Bug description

SponsorBlock skips random sections of shorts for no reason making them unwatchable. I have confirmed that this is a client bug in the SponsorBlock repo. Shorts don't have sponsored segments or intros so nothing should be skipped.

Steps to reproduce

  1. Play shorts.
  2. Stumble upon an affected one.
  3. Notice how random sections are skipped (either as Sponsored or as Self-Promotion most likely).

Relevant log output

Not sure how to access the log. But even if I did, I'm not sure any output would be relevant.

Screenshots or videos

No response

Solution

Disable SponsorBlock for shorts.

Additional context

No response

Acknowledgements

oSumAtrIX commented 1 year ago

Please attach an example short.

george-emerald commented 1 year ago

It's hard to stumble upon it, since it doesn't happen frequently. It could also be related to other videos you're watching. For example, it could only happen if you're watching a video that has an early sponsored segment and that's transferred to the short.

It shouldn't happen at all, however. Shorts don't have anything that SponsorBlock should block so they should be an exception. It's pretty easy to make SponsorBlock not run on videos that are shorts-length.

Also, this isn't a question.

oSumAtrIX commented 1 year ago

Shorts can very well have segments which could be skipped by SponsorBlock. Please add a short when you find one.

george-emerald commented 1 year ago

I found one here. I haven't watched any normal video so we can rule out carry over. It doesn't have any sponsored content. The start is just skipped for no reason at all.

https://youtube.com/shorts/BZ0c6K2ejfE?feature=share

george-emerald commented 1 year ago

It skips part of the video here as well, where there's no sponsor or anything similar.

https://youtube.com/shorts/KK4o10Digtg?feature=share

george-emerald commented 1 year ago

Shorts aren't long enough to add sponsors, self-promotions or reminders which are the only categories set to be skipped automatically. So, I'm not sure what you're referring to. No such segments that SponsorBlock could skip are ever present.

oSumAtrIX commented 1 year ago

https://user-images.githubusercontent.com/13122796/201331173-edfe0279-08a1-400e-a6ad-6ce056949061.mp4

oSumAtrIX commented 1 year ago

It is not skipping for me. Disable all patches and record the issue with the patch causing the issue.

george-emerald commented 1 year ago

The video you opened skips much later than what you showed in your recording. Did you watch the whole video? The first one I linked is the one that skips at the start of it.

oSumAtrIX commented 1 year ago

It does not skip the video: https://user-images.githubusercontent.com/13122796/201333099-018151cb-7eb1-4307-abcc-9b01c2e30afb.mp4

The first video also does not skip.

george-emerald commented 1 year ago

Hmmm OK. The APK I used wasn't taken from your official site, so I'll try reinstalling with your APK to see if that fixes the issue.

george-emerald commented 1 year ago

That fixed it. It was a problem with the APK I downloaded, sorry for taking up your time.

george-emerald commented 1 year ago

Actually SponsorBlock isn't working at all now that I reinstalled with your APK. Which is why nothing was skipped. I'll wait for it to start working and get back to you. Do you know why it could be not working at all? Should I delete all data before uninstalling or something?

oSumAtrIX commented 1 year ago

SponsorBlock is currently down.

george-emerald commented 1 year ago

OK, I'll let you know if this issue persists when it's back up. If it doesn't, I'll let you know and close it.

george-emerald commented 1 year ago

SponsorBlock is back up and the bug is gone. Looks like it was the APK I had.