search

ReVanced / revanced-patches

🧩 Patches for ReVanced
https://revanced.app
GNU General Public License v3.0
2.19k stars 254 forks source link

bug: <Still seeing ads before videos, but not when SponsorBlock is deactivated or I'm logged out> #1999

Closed arturfast closed 1 year ago

arturfast commented 1 year ago

Type

Error at runtime

Bug description

I see ads before videos, but only when I'm logged into an account, or when I have SponsorBlock turned on. When I turn it off, or log out, the ads are gone. I have the general ad patch included and activated. The issue persists on both my Samsung Galaxy S7 running Android 8, and my S5 running LineageOS (Android 11).

Steps to reproduce

I downloaded the patches from github, the cli tool, the instructions, and a YouTube APK of version 17.36.37. I executed the cli tool as described in the documentation, I only added the -m option with the integrations (app-release-unsigned.apk), and changed the color option in options.toml. I used all patches available in the latest release. Then installed it with adb.

java -jar revanced-cli-2.13.0-all.jar -a youtube-17.36.37.apk -c -o test.apk -b revanced-patches-2.77.1.jar -m app-release-unsigned.apk &> logs.txt

Relevant log output

Output of logs.txt from above: 

Picked up _JAVA_OPTIONS: -Dawt.useSystemAAFontSettings=on -Dswing.aatext=true
INFO: Reading dex files 
INFO: Decoding AndroidManifest.xml only, because resources are not needed 
INFO: Merging app-release-unsigned.apk 
WARNING: Skipping general-reddit-ads, reason: incompatible with com.google.android.youtube. This patch is only compatible with com.reddit.frontpage 
WARNING: Skipping premium-icon-reddit, reason: incompatible with com.google.android.youtube. This patch is only compatible with com.reddit.frontpage 
WARNING: Skipping hide-premium-navbar, reason: incompatible with com.google.android.youtube. This patch is only compatible with com.spotify.music 
WARNING: Skipping disable-capture-restriction, reason: incompatible with com.google.android.youtube. This patch is only compatible with com.spotify.music 
WARNING: Skipping spotify-theme, reason: incompatible with com.google.android.youtube. This patch is only compatible with com.spotify.music 
WARNING: Skipping promo-code-unlock, reason: incompatible with com.google.android.youtube. This patch is only compatible with de.dwd.warnapp 
WARNING: Skipping pflotsh-ecmwf-subscription-unlock, reason: incompatible with com.google.android.youtube. This patch is only compatible with com.garzotto.pflotsh.ecmwf_a 
WARNING: Skipping tiktok-speed, reason: incompatible with com.google.android.youtube. This patch is only compatible with com.ss.android.ugc.trill, com.zhiliaoapp.musically 
WARNING: Skipping tiktok-download, reason: incompatible with com.google.android.youtube. This patch is only compatible with com.ss.android.ugc.trill, com.zhiliaoapp.musically 
WARNING: Skipping tiktok-seekbar, reason: incompatible with com.google.android.youtube. This patch is only compatible with com.ss.android.ugc.trill, com.zhiliaoapp.musically 
WARNING: Skipping tiktok-force-login, reason: incompatible with com.google.android.youtube. This patch is only compatible with com.ss.android.ugc.trill, com.zhiliaoapp.musically 
WARNING: Skipping tiktok-settings, reason: incompatible with com.google.android.youtube. This patch is only compatible with com.ss.android.ugc.trill, com.zhiliaoapp.musically 
WARNING: Skipping tiktok-ads, reason: incompatible with com.google.android.youtube. This patch is only compatible with com.ss.android.ugc.trill, com.zhiliaoapp.musically 
WARNING: Skipping tiktok-feed-filter, reason: incompatible with com.google.android.youtube. This patch is only compatible with com.ss.android.ugc.trill, com.zhiliaoapp.musically 
WARNING: Skipping monochrome-icon, reason: incompatible with com.google.android.youtube. This patch is only compatible with com.twitter.android 
WARNING: Skipping dynamic-color, reason: incompatible with com.google.android.youtube. This patch is only compatible with com.twitter.android 
WARNING: Skipping timeline-ads, reason: incompatible with com.google.android.youtube. This patch is only compatible with com.twitter.android 
WARNING: Skipping exclusive-audio-playback, reason: incompatible with com.google.android.youtube. This patch is only compatible with com.google.android.apps.youtube.music 
WARNING: Skipping codecs-unlock, reason: incompatible with com.google.android.youtube. This patch is only compatible with com.google.android.apps.youtube.music 
WARNING: Skipping music-microg-support, reason: incompatible with com.google.android.youtube. This patch is only compatible with com.google.android.apps.youtube.music 
WARNING: Skipping music-video-ads, reason: incompatible with com.google.android.youtube. This patch is only compatible with com.google.android.apps.youtube.music 
WARNING: Skipping tasteBuilder-remover, reason: incompatible with com.google.android.youtube. This patch is only compatible with com.google.android.apps.youtube.music 
WARNING: Skipping minimized-playback-music, reason: incompatible with com.google.android.youtube. This patch is only compatible with com.google.android.apps.youtube.music 
INFO: Skipping compact-header, reason: excluded by default 
WARNING: Skipping upgrade-button-remover, reason: incompatible with com.google.android.youtube. This patch is only compatible with com.google.android.apps.youtube.music 
WARNING: Skipping hide-get-premium, reason: incompatible with com.google.android.youtube. This patch is only compatible with com.google.android.apps.youtube.music 
WARNING: Skipping background-play, reason: incompatible with com.google.android.youtube. This patch is only compatible with com.google.android.apps.youtube.music 
INFO: Skipping enable-debugging, reason: excluded by default 
INFO: Deleting existing resource cache directory 
INFO: Decoding resources 
INFO: swipe-controls succeeded 
INFO: downloads succeeded 
INFO: seekbar-tapping succeeded 
INFO: remember-video-quality succeeded 
INFO: custom-playback-speed succeeded 
INFO: minimized-playback succeeded 
INFO: client-spoof succeeded 
INFO: custom-video-buffer succeeded 
INFO: settings succeeded 
INFO: microg-support succeeded 
INFO: hdr-auto-brightness succeeded 
INFO: always-autorepeat succeeded 
INFO: general-ads succeeded 
INFO: hide-infocard-suggestions succeeded 
INFO: video-ads succeeded 
INFO: hide-time-and-seekbar succeeded 
INFO: old-quality-layout succeeded 
INFO: enable-wide-searchbar succeeded 
INFO: disable-fullscreen-panels succeeded 
INFO: hide-autoplay-button succeeded 
INFO: disable-startup-shorts-player succeeded 
INFO: premium-heading succeeded 
INFO: custom-branding succeeded 
INFO: hide-create-button succeeded 
INFO: hide-shorts-button succeeded 
INFO: theme succeeded 
INFO: hide-email-address succeeded 
INFO: sponsorblock succeeded 
INFO: hide-cast-button succeeded 
INFO: tablet-mini-player succeeded 
INFO: return-youtube-dislike succeeded 
INFO: hide-watermark succeeded 
INFO: disable-auto-player-popup-panels succeeded 
INFO: disable-auto-captions succeeded 
INFO: Compiling resources 
INFO: Writing modified dex files 
INFO: Writing dex file classes2.dex 
INFO: Writing dex file classes.dex 
INFO: Writing dex file classes4.dex 
INFO: Writing dex file classes3.dex 
INFO: Writing dex file classes5.dex 
INFO: Writing dex file classes6.dex 
INFO: Writing dex file classes8.dex 
INFO: Writing dex file classes7.dex 
INFO: Writing resources... 
INFO: Aligning test_raw.apk to test_aligned.apk 
INFO: Signing test_aligned.apk to test_signed.apk 
INFO: Copying test_signed.apk to test.apk 
INFO: Cleaned up cache directory 
INFO: Finished

Screenshots or videos

No response

Solution

No response

Additional context

No response

Acknowledgements

oSumAtrIX commented 1 year ago

Dupe of ReVanced/revanced-patches-template#2067.