ReVanced / revanced-patches

🧩 Patches for ReVanced
https://revanced.app
GNU General Public License v3.0
2.43k stars 281 forks source link

bug: ReTwitter ads still showing on main timeline on Android 13 #2245

Closed johnossawy closed 1 year ago

johnossawy commented 2 years ago

Type

Other

Bug description

Installed ReTwitter using revanced builder on Android and installed ReVanced-Twitter-v9.54.1-release.0-ar m64-v8a-cli 2.9.3-all-v2.9.3.jarpatche s_2.38.0-v2.38.0.apk. Upon lunch and login to the app, ads are still showing on the main timeline

Steps to reproduce

Open Twitter login main timeline loads with ads

Relevant log output

N/A

Screenshots or videos

Screenshot showing a promoted ad on the main timeline

image

App details image

Solution

N/A

Additional context

Phone: Pixel 6 Pro OS: Android 13 Build Number: TP1A.220624.021

Running the latest public release of Android 13

oSumAtrIX commented 2 years ago

Did you clear the cache?

johnossawy commented 2 years ago

Yip, cleared cache, also cleared storage have tried fresh install and also tried the previous version. Ads still showing on the main timeline

oSumAtrIX commented 2 years ago

Follow the official documentation and respond back with logs & check if it worked

Flat commented 2 years ago

Same issue for me. Seems to be happening with anything newer than 9.50 twitter.

CLI patch log

``` ❯ java -jar ~\Documents\revanced\revanced-cli.jar -c -b ~\Documents\revanced\revanced-patches.jar --keystore ~\Documents\revanced\revancedtwitter.keystore -d 19261FDEE006XD -a Downloads\Twitter_v9.56.2-release.0_apkpure.com.apk -o Downloads\Twitter.apk INFO: Decoding resources INFO: Reading dex files WARNING: Skipping general-reddit-ads: Incompatible with com.twitter.android. This patch is only compatible with com.reddit.frontpage WARNING: Skipping pflotsh-ecmwf-subscription-unlock: Incompatible with com.twitter.android. This patch is only compatible with com.garzotto.pflotsh.ecmwf_a WARNING: Skipping minimized-playback-music: Incompatible with com.twitter.android. This patch is only compatible with com.google.android.apps.youtube.music WARNING: Skipping tasteBuilder-remover: Incompatible with com.twitter.android. This patch is only compatible with com.google.android.apps.youtube.music WARNING: Skipping hide-get-premium: Incompatible with com.twitter.android. This patch is only compatible with com.google.android.apps.youtube.music INFO: Skipping compact-header: Not explicitly included WARNING: Skipping upgrade-button-remover: Incompatible with com.twitter.android. This patch is only compatible with com.google.android.apps.youtube.music WARNING: Skipping background-play: Incompatible with com.twitter.android. This patch is only compatible with com.google.android.apps.youtube.music WARNING: Skipping music-microg-support: Incompatible with com.twitter.android. This patch is only compatible with com.google.android.apps.youtube.music WARNING: Skipping music-video-ads: Incompatible with com.twitter.android. This patch is only compatible with com.google.android.apps.youtube.music WARNING: Skipping codecs-unlock: Incompatible with com.twitter.android. This patch is only compatible with com.google.android.apps.youtube.music WARNING: Skipping exclusive-audio-playback: Incompatible with com.twitter.android. This patch is only compatible with com.google.android.apps.youtube.music WARNING: Skipping promo-code-unlock: Incompatible with com.twitter.android. This patch is only compatible with de.dwd.warnapp WARNING: Skipping tiktok-ads: Incompatible with com.twitter.android. This patch is only compatible with com.ss.android.ugc.trill, com.zhiliaoapp.musically WARNING: Skipping swipe-controls: Incompatible with com.twitter.android. This patch is only compatible with com.google.android.youtube WARNING: Skipping downloads: Incompatible with com.twitter.android. This patch is only compatible with com.google.android.youtube WARNING: Skipping seekbar-tapping: Incompatible with com.twitter.android. This patch is only compatible with com.google.android.youtube WARNING: Skipping amoled: Incompatible with com.twitter.android. This patch is only compatible with com.google.android.youtube WARNING: Skipping disable-create-button: Incompatible with com.twitter.android. This patch is only compatible with com.google.android.youtube WARNING: Skipping hide-cast-button: Incompatible with com.twitter.android. This patch is only compatible with com.google.android.youtube WARNING: Skipping return-youtube-dislike: Incompatible with com.twitter.android. This patch is only compatible with com.google.android.youtube WARNING: Skipping hide-autoplay-button: Incompatible with com.twitter.android. This patch is only compatible with com.google.android.youtube WARNING: Skipping premium-heading: Incompatible with com.twitter.android. This patch is only compatible with com.google.android.youtube WARNING: Skipping disable-fullscreen-panels: Incompatible with com.twitter.android. This patch is only compatible with com.google.android.youtube WARNING: Skipping old-quality-layout: Incompatible with com.twitter.android. This patch is only compatible with com.google.android.youtube WARNING: Skipping hide-shorts-button: Incompatible with com.twitter.android. This patch is only compatible with com.google.android.youtube WARNING: Skipping hide-watermark: Incompatible with com.twitter.android. This patch is only compatible with com.google.android.youtube WARNING: Skipping sponsorblock: Incompatible with com.twitter.android. This patch is only compatible with com.google.android.youtube WARNING: Skipping enable-wide-searchbar: Incompatible with com.twitter.android. This patch is only compatible with com.google.android.youtube WARNING: Skipping tablet-mini-player: Incompatible with com.twitter.android. This patch is only compatible with com.google.android.youtube WARNING: Skipping minimized-playback: Incompatible with com.twitter.android. This patch is only compatible with com.google.android.youtube WARNING: Skipping custom-video-buffer: Incompatible with com.twitter.android. This patch is only compatible with com.google.android.youtube WARNING: Skipping always-autorepeat: Incompatible with com.twitter.android. This patch is only compatible with com.google.android.youtube WARNING: Skipping microg-support: Incompatible with com.twitter.android. This patch is only compatible with com.google.android.youtube WARNING: Skipping settings: Incompatible with com.twitter.android. This patch is only compatible with com.google.android.youtube INFO: Skipping enable-debugging: Not explicitly included WARNING: Skipping custom-playback-speed: Incompatible with com.twitter.android. This patch is only compatible with com.google.android.youtube WARNING: Skipping hdr-auto-brightness: Incompatible with com.twitter.android. This patch is only compatible with com.google.android.youtube WARNING: Skipping remember-video-quality: Incompatible with com.twitter.android. This patch is only compatible with com.google.android.youtube WARNING: Skipping video-ads: Incompatible with com.twitter.android. This patch is only compatible with com.google.android.youtube WARNING: Skipping general-ads: Incompatible with com.twitter.android. This patch is only compatible with com.google.android.youtube WARNING: Skipping hide-infocard-suggestions: Incompatible with com.twitter.android. This patch is only compatible with com.google.android.youtube INFO: timeline-ads succeeded INFO: Compiling resources INFO: Writing modified dex files INFO: Writing dex file classes.dex INFO: Writing dex file classes2.dex INFO: Writing dex file classes3.dex INFO: Writing dex file classes4.dex INFO: Writing dex file classes5.dex INFO: Writing dex file classes6.dex INFO: Writing dex file classes7.dex INFO: Writing dex file classes11.dex INFO: Writing dex file classes9.dex INFO: Writing dex file classes10.dex INFO: Writing dex file classes8.dex INFO: Writing dex file classes12.dex INFO: Writing resources... INFO: Aligning Twitter_raw.apk to Twitter_aligned.apk INFO: Signing Twitter_aligned.apk to Twitter_signed.apk INFO: Found existing keystore: revancedtwitter.keystore INFO: Copying Twitter_signed.apk to Twitter.apk INFO: Cleaned up cache directory INFO: Installing without mounting INFO: Finished ```

beygolu commented 2 years ago

Has the problem been fixed?

dvvmvp commented 1 year ago

I've got the same problem (A13, Nov patch). The latest Twitter version that was working fine is 9.63.

quyleanh commented 1 year ago

Same here... I tried many version but it still doesn't work. Looking forward to getting support this patch.

ciltocruz commented 1 year ago

Same for me.

Twitter v9.68.1 Pixel 6a

pratyakshm commented 1 year ago

I've been facing the same issue. Android 13 Twitter version 9.69.1-release.0 ReVanced Manager version 0.0.52

pratyakshm commented 1 year ago

What's with all the comments also reporting the same issue being marked as spam? Would love to understand the logic here.

oSumAtrIX commented 1 year ago

"Same" adds no value to an issue and is being commented in masses here which makes it applicable under the term "Spam".

Ushie commented 1 year ago

What's with all the comments also reporting the same issue being marked as spam? Would love to understand the logic here.

"also reporting the same issue" is your answer

progre commented 1 year ago

I tested it works with 9.65.3, not with 9.65.5 on Pixel 7 Android 13.

kbexit commented 1 year ago

I still get them as well. Deleted, patched and installed again, cleared storage and cache. Force closed. Cleared again, force stop, and then uninstall and reinstall. Still there. Screenshot_20230211-143618.png

Version 9.69.1-release.0 Pixel 6 Pro Android 13

LisoUseInAIKyrios commented 1 year ago

timeline-ads should be updated to require 9.63, 9.64, or 9.65.3 But hide-views-stats is not compatible with any of these versions (it throws a null pointer exception during patching). The last version it's compatible with is 9.71.0

This means users must either patch with a newer version of Twitter (and get more ads) Or patch with an older version of Twitter and not include hide-views-stats (this also requires enabling experimental patching)

It seems that users want robust ad blocking more than hiding a tweet statistic.

For now, I think:

Then if someone really, really wants hide-views-stats with some ads, they can enable experimental patching and go their own way. But for everyone else, they can use default patches, Twitter 9.65.3 and they'll get no ads (and tweets will still show the view statistics)