ReVanced / revanced-patches

🧩 Patches for ReVanced
https://revanced.app
GNU General Public License v3.0
2.13k stars 245 forks source link

bug: Several Patches failing in Youtube 17.49.37 #2477

Closed Vucko130 closed 8 months ago

Vucko130 commented 1 year ago

Type

Error while patching

Bug description

Several apps failing to patch in latest Youtube 17.49.37 I am using latest revanced manager. I have also tried using unofficial builders. They failed too.

Steps to reproduce

Patch the app in revanced manager or any other unofficial builder

Relevant log output

Initializing installer
Creating working directory
Copying original apk
Unpacking input apk
Reading dex files
Decoding AndroidManifest.xml only, because resources are not needed
Merging integrations
Deleting existing resource cache directory
Decoding resources
Applied always-autorepeat
Applied client-spoof
Failed to apply comments: 'comments' depends on 'comments-resource-patch' but the following error was raised: 'comments-resource-patch' depends on 'settings' but the following error was raised: Failed to resolve ThemeSetterAppFingerprint
Failed to apply custom-video-buffer: 'custom-video-buffer' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Applied custom-video-speed
Failed to apply debugging: 'debugging' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Failed to apply disable-auto-captions: 'disable-auto-captions' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Failed to apply disable-auto-player-popup-panels: 'disable-auto-player-popup-panels' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Failed to apply disable-fullscreen-panels: 'disable-fullscreen-panels' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Failed to apply disable-startup-shorts-player: 'disable-startup-shorts-player' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Failed to apply disable-zoom-haptics: 'disable-zoom-haptics' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Failed to apply downloads: 'downloads' depends on 'downloads-resource-patch' but the following error was raised: 'downloads-resource-patch' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Failed to apply enable-wide-searchbar: 'enable-wide-searchbar' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Failed to apply general-ads: 'general-ads' depends on 'GeneralAdsResourcePatch' but the following error was raised: 'GeneralAdsResourcePatch' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Failed to apply hdr-auto-brightness: 'hdr-auto-brightness' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Failed to apply hide-album-cards: 'hide-album-cards' depends on 'hide-album-cards-resource-patch' but the following error was raised: 'hide-album-cards-resource-patch' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Applied hide-artist-card
Failed to apply hide-autoplay-button: 'hide-autoplay-button' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Failed to apply hide-captions-button: 'hide-captions-button' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Failed to apply hide-cast-button: 'hide-cast-button' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Failed to apply hide-create-button: 'hide-create-button' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Failed to apply hide-crowdfunding-box: 'hide-crowdfunding-box' depends on 'crowdfunding-box-resource-patch' but the following error was raised: 'crowdfunding-box-resource-patch' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Failed to apply hide-email-address: 'hide-email-address' depends on 'hide-email-address-resource-patch' but the following error was raised: 'hide-email-address-resource-patch' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Failed to apply hide-endscreen-cards: 'hide-endscreen-cards' depends on 'hide-endscreen-cards-resource-patch' but the following error was raised: 'hide-endscreen-cards-resource-patch' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Failed to apply hide-info-cards: 'hide-info-cards' depends on 'HideInfocardsResourcePatch' but the following error was raised: 'HideInfocardsResourcePatch' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Applied hide-my-mix
Failed to apply hide-shorts-button: 'hide-shorts-button' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Failed to apply hide-time-and-seekbar: 'hide-time-and-seekbar' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Applied hide-video-buttons
Failed to apply hide-watch-in-vr: 'hide-watch-in-vr' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Failed to apply hide-watermark: 'hide-watermark' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Failed to apply microg-support: 'microg-support' depends on 'hide-cast-button' but the following error was raised: 'hide-cast-button' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Failed to apply minimized-playback: 'minimized-playback' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Failed to apply old-quality-layout: 'old-quality-layout' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Failed to apply open-links-directly: 'open-links-directly' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Applied premium-heading
Failed to apply remember-video-quality: 'remember-video-quality' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Applied remove-player-button-background
Failed to apply return-youtube-dislike: 'return-youtube-dislike' depends on 'return-youtube-dislike-resource-patch' but the following error was raised: 'return-youtube-dislike-resource-patch' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Failed to apply seekbar-tapping: 'seekbar-tapping' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Failed to apply settings: 'settings' did not succeed previously
Failed to apply sponsorblock: 'sponsorblock' depends on 'sponsorblock-resource-patch' but the following error was raised: 'sponsorblock-resource-patch' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Failed to apply swipe-controls: 'swipe-controls' depends on 'swipe-controls-resource-patch' but the following error was raised: 'swipe-controls-resource-patch' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Failed to apply video-ads: 'video-ads' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Repacking patched apk
Compiling resources
Writing modified dex files
Finished!

Screenshots or videos

Screenshot_20221219-085606 Screenshot_20221219-085613_ReVanced_Manager Screenshot_20221219-085619_ReVanced_Manager Screenshot_20221219-085624_ReVanced_Manager Screenshot_20221219-085627_ReVanced_Manager

Solution

No response

Additional context

No response

Acknowledgements

oSumAtrIX commented 1 year ago

You are using outdated patches.

Vucko130 commented 1 year ago

You are using outdated patches.

How can it be? 2.146.0 patches are the latest one. Screenshot_20221219-092452

oSumAtrIX commented 1 year ago

Please add a recording of the following:

  1. Close and open the ReVanced Manager
  2. Patch the app
  3. Show that it is failing
Vucko130 commented 1 year ago

sure. give me some minutes to do that

Vucko130 commented 1 year ago

File size is 39mb. Github Supports max 10mb. That's why I am sharing youtube link. screen 20221219 094328

Vucko130 commented 1 year ago

i hope that helps

oSumAtrIX commented 1 year ago

Please try with all recommended patches selected, if that works find the minimum subset of patches which fail.

Vucko130 commented 1 year ago

Please try with all recommended patches selected, if that works find the minimum subset of patches which fail.

Repacked apk with all the recommended patches just now. But that failed too.

oSumAtrIX commented 1 year ago

I can not reproduce, reinstalling the ReVanced Manager

Vucko130 commented 1 year ago

I don't know either why this is happening. If I use unofficial builder on my PC then only some of the patches fail. But with official revanced manager on my mobile 99% of the patches are failing today. I tried reinstalling ReVanced Manager several times too.

oSumAtrIX commented 1 year ago

Please try reinstalling the ReVanced Manager

Vucko130 commented 1 year ago

Please try reinstalling the ReVanced Manager

I have done that multiple times already 😔

Mygod commented 1 year ago

I ran into the same issue but somehow patching a second time fixed it. (I might be patching over the patched apk file?)

nikhilbadyal commented 1 year ago

Doesn't work for me too.

I have downloaded the latest cli- 2.18.2 Patches - 2.146.0 Integration - 0.84.1

Still return dislike fails. Logs can be found here or here

mikhail5555 commented 1 year ago

The solution in this thread worked for me: https://www.reddit.com/r/revancedapp/comments/zphzx1/how_do_i_solve_this/j0tud6h/

Vucko130 commented 1 year ago

The solution in this thread worked for me: https://www.reddit.com/r/revancedapp/comments/zphzx1/how_do_i_solve_this/j0tud6h/

Worked for me too.

nikhilbadyal commented 1 year ago

I built it on pc. So not sure what to do in my case.

Vucko130 commented 1 year ago

I built it on pc. So not sure what to do in my case.

yeah. still can't solve it on pc. returnyoutubedislike failing on pc.