Open Jeanfeels opened 9 months ago
What you are seeing is the expected behavior for the current implementation.
The DeArrow thumbnail service provides a user selected thumbnail, or if no user selected thumbnail is available it sometimes provides a screen capture of a random video time.
Currently the /api/v1/getThumbnail
end point does not allow requesting only user selected thumbnails.
This could be fixed by either:
ReVanced can make an additional DeArrow API call (/api/branding
) and check if any user generated thumbnails exist, and then not use DeArrow if a video has only random screen captures. This will increase the loading time of thumbnails since it adds an extra round trip API call.
DeArrow thumbnail end point could add an extra parameter to return only user selected thumbnails.
Option 2 is the best solution, but it requires DeArrow to add the API parameter.
What you are seeing is the expected behavior for the current implementation.
The DeArrow thumbnail service provides a user selected thumbnail, or if no user selected thumbnail is available it sometimes provides a screen capture of a random video time.
Currently the
/api/v1/getThumbnail
end point does not allow requesting only user generated thumbnails.This could be fixed by either:
1. ReVanced can make an additional DeArrow API call (`/api/branding`) and check if any user generated thumbnails exist, and then not use DeArrow if a video has only random screen captures. This will increase the loading time of thumbnails since it adds an extra round trip API call. 2. DeArrow thumbnail end point could add an extra parameter to return only user generated thumbnails.
Option 2 is the best solution, but it requires DeArrow to add the API parameter.
@ajayyy what do you think about this?
Bug description
Expected behaviour with DeArrow enabled:
Actual behaviour with DeArrow enabled:
Proof video has no submitted thumbnails, and thus should be using the original thumbnail:
Proof of correct settings in revanced:
Error logs
Solution
Check implementation and ensure this behaviour is adhered to properly by default
Additional context
No response
Acknowledgements