bug(YouTube - Disable resuming Shorts player): Patch does not always work with YT 19.04.37+

cyberboh commented 7 months ago

Bug description

Whenever i open YT after closed it while playing Shorts video, the short it self is playing automatically. The Hide button Disable resuming Shorts player does not work.

Patched with CLI:

java -jar revanced-cli-4.4.0-all.jar patch -p -o Install\YouTube_19.04.37-all_ReVanced.apk --options options.json -b revanced-patches-4.3.0-dev.2.jar --alias=******** --keystore-password=*********** --keystore-entry-password=******** --keystore=********.keystore -m revanced-integrations-1.4.0-dev.2.apk Apps\com.google.android.youtube-19.04.37-all.apk -i "Change header"

How to reproduce:

Enable Disable resuming Shorts player
Playing some shorts
Force stop YT (clear from recents)
Open YT again
Short will be playing

Error logs

No response

Solution

No response

Additional context

No response

Acknowledgements

[X] This issue is not a duplicate of an existing bug report.
[X] I have chosen an appropriate title.
[X] All requested information has been provided properly.

LisoUseInAIKyrios commented 7 months ago

The patch is working for me.

The patch prevents resuming the Shorts player when the app is cold launched.

To verify this:

open ReVanced YT
open a Short
close the app
stop the app from running in the background
relaunch the app

If the patch is enabled, YT will launch and open the home feed.

If the patch is not enabled, the Shorts player will resume.

LisoUseInAIKyrios commented 7 months ago

If Shorts are resuming, then post a video showing the behavior.

cyberboh commented 7 months ago

The patch prevents resuming the Shorts player when the app is cold launched.

To verify this:
* open ReVanced YT

* open a Short

* close the app

* stop the app from running in the background

* relaunch the app
If the patch is enabled, YT will launch and open the home feed.

If the patch is not enabled, the Shorts player will resume.

Patch is enabled, but YT is resuming shorts player

cyberboh commented 7 months ago

If Shorts are resuming, then post a video showing the behavior.

https://github.com/ReVanced/revanced-patches/assets/99109969/fd3f7675-2604-452a-8b8d-b07f68b5e7a0

LisoUseInAIKyrios commented 7 months ago

Are you sure the app was closed in the background?

Try turning on incognito mode and try again.

Also try turning on version spoofing with spoof target 18.09.39.

19.04.x has changes to the code for resuming Shorts. The patch is working for me, but maybe there is some new code that's enabled for some users.

cyberboh commented 7 months ago

Are you sure the app was closed in the background?

Try turning on incognito mode and try again.

Also try turning on version spoofing with spoof target 18.09.39.

19.04.x has changes to the code for resuming Shorts. The patch is working for me, but maybe there is some new code that's enabled for some users.

I'm sure. In my device, clear recents is enough to force stopping all opened apps.

Turning on incognito and spoofing app to 18.09.39 is same, Shorts still resuming.

I'll try to patch 19.03.36 and see

cyberboh commented 7 months ago

@LisoUseInAIKyrios YT 19.03.36 is fine though, the patch is working.

oSumAtrIX commented 6 months ago

Does this issue still occur? I can not reproduce it.

LisoUseInAIKyrios commented 6 months ago

@oSumAtrIX with 19.09 this is now showing up for me. It must be an a/b change to use new code for resuming Shorts.

ReVanced / revanced-patches