ReVanced / revanced-patches

🧩 Patches for ReVanced
https://revanced.app
GNU General Public License v3.0
1.98k stars 232 forks source link

bug(YouTube - Hide ads): Patch can change the back button behavior #2756

Open uk6120 opened 4 months ago

uk6120 commented 4 months ago

Bug description

• Pressing back button on home feed while scrolling instantly quits ReVanced YouTube. However checking this on stock YouTube app doesn't happen, pressing back button on home feed while scrolling gets back up on the initial point of the feed.

• Patches using - "Bypass URL redirects" "Change Header" "Client Spoof" "Custom Branding" "GmsCore Support" "Hide Ads" "Open Links Externally" "Remember Video Quality" "Return YouTube Dislike" "SponsorBlock" "Video Ads"

https://github.com/ReVanced/revanced-patches/assets/116729059/b6a7f744-44b6-4e3d-9dca-c281a9929560

Error logs

No response

Solution

Disabling "Hide Ads" patch has fixed this issue, however this enabled ads on home feed. Screenshot_20240221-145910 Screenshot_20240221-145927 Screenshot_20240221-134937

https://github.com/ReVanced/revanced-patches/assets/116729059/d9acf9ac-80dc-42a9-aebb-594418ccd9ca

Additional context

No response

Acknowledgements

LisoUseInAIKyrios commented 4 months ago

Try including hide ads during patching, and turn off the various hide ad types in the ReVanced settings. See if you can find which function changes the back button.

oSumAtrIX commented 4 months ago

That's because of a workaround that's necessary to make back to exit work.

uk6120 commented 4 months ago

Try including hide ads during patching, and turn off the various hide ad types in the ReVanced settings. See if you can find which function changes the back button.

I did tried doing that, but unfortunately the whole patch seems to be bounded with this issue.

uk6120 commented 4 months ago

That's because of a workaround that's necessary to make back to exit work.

Ah okay thank you for your support. Although I don't really mind this issue at all.