ReVanced / revanced-patches

🧩 Patches for ReVanced
https://revanced.app
GNU General Public License v3.0
2.47k stars 286 forks source link

feat(RedditSync): Fix v.redd.it thumbnails #2775

Open asandhu3 opened 8 months ago

asandhu3 commented 8 months ago

Feature description

Video posts with domain v.redd.it are missing thumbnails in the app. That is the only domain I've noticed with this issue.

Motivation

Other than the obvious use-case for thumbnails in general, thumbnails are a core portion of the browsing experience in this app (depending on which layout is being used). Now that more and more users are posting to reddit via v.redd.it since it is the default, this issue is becoming more apparent and increasingly affects the experience negatively.

Acknowledgements

oSumAtrIX commented 8 months ago

Send a link to such a post.

asandhu3 commented 8 months ago

Front page or /r/all usually has at least one on the first page but here's one I can see currently, and an attached screenshot.

Screenshot_20240226-211652

https://v.redd.it/a6axe1i1c0lc1/

oSumAtrIX commented 8 months ago

I am not able to reproduce this. Does this occur in other view modes such as that where the image is in fullscreen?

asandhu3 commented 8 months ago

"Cards" and "Slides" view modes both show the thumbnails, all others do not. This seems to be a relatively widespread issue, I've found a few reddit threads discussing other's experience:

https://www.reddit.com/r/redditsync/comments/12spu3f/a_lot_of_thumbnails_are_not_showing_on_compact/ https://www.reddit.com/r/redditsync/comments/12ikpw1/reddit_hosted_gifs_not_showing_thumbnail_preview/ https://www.reddit.com/r/redditsync/comments/12lml2c/bug_video_thumbnails_are_not_displaying/

For reference, the first page of /r/Damnthatsinteresting currently has 13 of 25 posts not showing thumbnails for me at the time of writing.