bug(YouTube - Disable suggested video endscreen): Suggested video thumbnail and autoplay button in minimized player

ILoveOpenSourceApplications commented 4 months ago

Bug description

While the user finishes watching a video, the preview when minimized shows a different video thumbnail as well as the autoplay button rather than the videos last frame and replay button. In ReVanced (with disable suggested video end screen turned on):

https://github.com/ReVanced/revanced-patches/assets/117499019/8af60690-e4cb-4628-adda-b4b51be72d56

In Stock YouTube:

https://github.com/ReVanced/revanced-patches/assets/117499019/d6961148-c94f-4d86-9f33-e56e24ecc9e7

Error logs

No response

Solution

No response

Additional context

The suggested video overlay is hidden if the user stays on portrait or full screen mode. But if minimized it bugs and shows the thumbnail of the suggested video with the autoplay button which disappears after previewing and minimizing once again.

Acknowledgements

[X] This issue is not a duplicate of an existing bug report.
[X] I have chosen an appropriate title.
[X] All requested information has been provided properly.

ILoveOpenSourceApplications commented 4 months ago

Replication steps: 1) Play a video. 2) Skip till there's 10 seconds left in the video. 3) Minimize the video and let it it play till the end. 4) Suggested video thumbnail and auto play button appears. 5) Expanding and minimizing fixes the issue.

ILoveOpenSourceApplications commented 1 month ago

There's a toggle in 'Autoplay' called Autoplay next video below which is an option called 'Mobile phone/tablet'. If turned off there'll be no suggested video end screen and if turned on it'll be there. So we can remove this patch, but guide the users to this option similar to how we are doing for the background playback option.

Edit: Please refer this comment for further clarity.

ILoveOpenSourceApplications commented 1 month ago

The commit was also provided by @inotia00.

ReVanced / revanced-patches