Custom Branding issue - Githubissues

ReVanced / revanced-patches

🧩 Patches for ReVanced

https://revanced.app

GNU General Public License v3.0

2.3k stars 265 forks source link

Custom Branding issue #2946

Closed nightznero closed 6 months ago

nightznero commented 6 months ago

Bug description

Helloz, Custom Branding Patch doesn't work at its should. Logo is set to normal yt and ReVanced still is applied (Video is compressed to fit GitHub but everything is visable i guess) https://github.com/ReVanced/revanced-patches/assets/61750641/2ac6c656-2410-453e-be48-dfda7a5dc368

Error logs

no errors

Solution

Switch to YT default icon

Additional context

No response

Acknowledgements

[X] This issue is not a duplicate of an existing bug report.
[X] I have chosen an appropriate title.
[ ] All requested information has been provided properly.

LisoUseInAIKyrios commented 6 months ago

In the video you picked only one option for custom branding (use stock app name), and did not pick a custom icon option.

You picked "do nothing", and instead should not include the patch at all to achieve that.

nightznero commented 6 months ago

In the video you picked only one option for custom branding (use stock app name), and did not pick a custom icon option.

You picked "do nothing", and instead should not include the patch at all to achieve that.

Yup,bcs there is only option to use Revanced logo or Custom Value So if i dont choose rv logo why rv logo is selected? For what reason no option and rv logo option results the same? o.O

oSumAtrIX commented 6 months ago

Because ReVanced Manager doesn't support null option values. An issue for that is open